shapefusion-devel

[Shapefusion-devel] patch: BMP export bug

[Gregory S. <wo...@tr...>]

Turns out Windows has this stupid concept of "text" and "binary" files,
and std i/o fstreams default to the wrong one. The patch attached fixes
all the ofstreams and ifstreams I could find, to use std::ios::binary
when opening the streams.

This solves BMP export problems (and color table import/export, I have
to assume) in Windows.

Gregory

Re: [Shapefusion-devel] patch: BMP export bug

[Tito D. C. <ti...@da...>]

Thanks. I did a quick test and (as expected) nothing seems different
under linux. Keep in mind that GIMP palettes are ASCII files, but your
change seems to make no difference anyway. Can you confirm that your
patch fixes things under win? I'll commit when you do.

BTW, stupid windows one more time.

Bye
Tito
-- 
Physics is reverse engineering

Re: [Shapefusion-devel] patch: BMP export bug

[Gregory S. <wo...@tr...>]

Tito Dal Canton wrote:
> Thanks. I did a quick test and (as expected) nothing seems different
> under linux. Keep in mind that GIMP palettes are ASCII files, but your
> change seems to make no difference anyway. Can you confirm that your
> patch fixes things under win? I'll commit when you do.

Things seem to work in Wine: I tried exporting bitmaps and color tables,
and importing color tables. Exporting bitmaps didn't work in Wine before
the patch, and do after the patch, so I assume it fixes it in Windows
proper as well.

std::ios::binary may be the right thing to do even for ASCII files like
GIMP palettes--they import into GIMP just fine.

> BTW, stupid windows one more time.

Of course.

Gregory