shapefusion-devel

[Shapefusion-devel] comments

[<ti...@da...>]

Hi, great job with the wxDoc branch. I have some comments...

I think the Shapes stuff is becoming really complicated with
respect to the old implementation. I wonder if all those
separate classes like ShapesColor are really necessary...
Since we aren't going to extend their functionalities with
new features, I'd prefer keeping the code as compact as
possible rather than spreading it over too many files. If
there was a thing I liked about the previous implementation,
it was the very fact that all Shapes related code was kept
inside the class Shapes, which was independent from
wxWidgets :-) Also, I think that the Files subdirectory
could be dropped and everything could be kept in the Shapes
one.

Since your commit fixing the Xcode project, I can't build on
OS X anymore. I seem to lack wx.framework or something like
that... How can I fix this? I'm using a rather old version
of wxWidgets, will it work by just upgrading?

I've checked out the wxDoc branch and will examine it more
carefully, and willy try to correct the Linux makefile.

Bye
Tito

Re: [Shapefusion-devel] comments

[tiennou <tie...@gm...>]

Le 26 f=C3=A9vr. 07 =C3=A0 16:00, ti...@da... a =C3=A9crit :

> Hi, great job with the wxDoc branch. I have some comments...
>
> I think the Shapes stuff is becoming really complicated with
> respect to the old implementation. I wonder if all those
> separate classes like ShapesColor are really necessary...
> Since we aren't going to extend their functionalities with
> new features, I'd prefer keeping the code as compact as
> possible rather than spreading it over too many files. If
> there was a thing I liked about the previous implementation,
> it was the very fact that all Shapes related code was kept
> inside the class Shapes, which was independent from
> wxWidgets :-) Also, I think that the Files subdirectory
> could be dropped and everything could be kept in the Shapes
> one.

As you wish ;-) I will recompress everything when I think there won't =20=

be anything big going in there...

> Since your commit fixing the Xcode project, I can't build on
> OS X anymore. I seem to lack wx.framework or something like
> that... How can I fix this? I'm using a rather old version
> of wxWidgets, will it work by just upgrading?

This is because I've built my own framework for use with ShapeFusion, =20=

which is not available right now...
I can send it to you, but the debug version I use is quite big =20
(500Mb). And as I needed room, I deleted my wxWidget source tree, =20
which means I cannot rebuild it now...
I will look into this as soon as I finish this. It shouldn't be a big =20=

problem of making it work with the current wx source tree.

> I've checked out the wxDoc branch and will examine it more
> carefully, and willy try to correct the Linux makefile.

I just (almost) completed loading/saving, now ShapeFusion 0.3 is able =20=

to read the files I save with my branch version. One bad point =20
though, frames are not displayed, there is the red X instead, so =20
there is obviously something wrong... I'm currently rewriting =20
accessors for Insert/Delete, so I can move to upgrading your View/=20
Browser widgets...

I'm glad there is not much left to do to make this (almost) final ;-).

tiennou

Re: [Shapefusion-devel] comments

[Tito D. C. <ti...@da...>]

On Mon, 2007-02-26 at 17:22 +0100, tiennou wrote:
> This is because I've built my own framework for use with ShapeFusion,
> which is not available right now...
> I can send it to you, but the debug version I use is quite big
> (500Mb). And as I needed room, I deleted my wxWidget source tree,
> which means I cannot rebuild it now...
> I will look into this as soon as I finish this. It shouldn't be a big
> problem of making it work with the current wx source tree.
Ah, thought that. No problem, we'll fix it before 0.3/0.4 release.


>  just (almost) completed loading/saving, now ShapeFusion 0.3 is able
> to read the files I save with my branch version. One bad point though,
> frames are not displayed, there is the red X instead, so there is
> obviously something wrong... I'm currently rewriting accessors for
> Insert/Delete, so I can move to upgrading your View/Browser widgets...
Curiouser and curiouser!

I'm thinking about committing my latest changes to the main trunk,
releasing 0.3 and then going on and completely merging the wxDoc stuff.
Then release 0.4. Is this good?

Bye!
Tito
-- 
Physics is reverse engineering

Re: [Shapefusion-devel] comments

[tiennou <tie...@gm...>]

Le 26 f=C3=A9vr. 07 =C3=A0 22:28, Tito Dal Canton a =C3=A9crit :

> On Mon, 2007-02-26 at 17:22 +0100, tiennou wrote:
>> This is because I've built my own framework for use with ShapeFusion,
>> which is not available right now...
>> I can send it to you, but the debug version I use is quite big
>> (500Mb). And as I needed room, I deleted my wxWidget source tree,
>> which means I cannot rebuild it now...
>> I will look into this as soon as I finish this. It shouldn't be a big
>> problem of making it work with the current wx source tree.
> Ah, thought that. No problem, we'll fix it before 0.3/0.4 release.
>
>
>>  just (almost) completed loading/saving, now ShapeFusion 0.3 is able
>> to read the files I save with my branch version. One bad point =20
>> though,
>> frames are not displayed, there is the red X instead, so there is
>> obviously something wrong... I'm currently rewriting accessors for
>> Insert/Delete, so I can move to upgrading your View/Browser =20
>> widgets...
> Curiouser and curiouser!
>
> I'm thinking about committing my latest changes to the main trunk,
> releasing 0.3 and then going on and completely merging the wxDoc =20
> stuff.
> Then release 0.4. Is this good?
Please do !
I'm reconverting back my wxList to std::vector, because it is less of =20=

a pain to use...

I'm having some thought on accessors for the new classes... Doesn't =20
it seems like overkill to have Getters/Setters for those ?

I finished redoing View/Browser stuff, but I can't seem to get it to =20
show... The window is still grey, but I get the "can't expand hidden =20
root" assert... Strange.

I'm commiting 2 times, because svn won't let me move/delete files =20
with modifications

tiennou=