Re: [Shapefusion-devel] opening bad files

[tiennou <tie...@gm...>]

Le 16 mars 07 à 17:56, Tito Dal Canton a écrit :

>> I got it working ;-). I' ve just overriden DoOpenDocument from
>> wxDocument to look at our mGoodData before telling that everything
>> went right...
>> Others changes are that as soon as an error is reported, loading
>> stops, as currently we were still trying to load after an error...
> Nice... But you somehow deleted a piece of code of mine! Compare
> ShapesDocument.cpp revision 33 with 34, in ShapesDocument::LoadObject.
> The code that checks whether file size is too small has been removed.
> Was it intentional? I think it's an important check, since there  
> aren't
> clear ways of identifying the shapes format.

Yes, that was intentional, because I tough it would be more efficient  
to check for loading errors than checking size... But it's right a  
Shapes file with an invalid number of headers is definitely not a  
Shape files, so that can be added back... I'll do it now...

> I'm pleased to see we are slowly converging to a stable 0.3-like app.
> Let me take care of bringing back commented code in ShapesView (bitmap
> and color table I/O to file).

I've handled the bitmap part by adding to ShapeBitmap the ability to  
load itself from a wxImage.
I'm feeling a little stuck with ColorTables though, due to the  
std::ofstream there...

You can revert anything you don't like in my bitmap handling though,  
if you don't like it.

tiennou