[Shapefusion-devel] things

[Tito D. C. <ti...@da...>]

Hi, I'm finally examining your branch and I'm happy to see what was
done. Good job! Code looks a lot more organized and clean (and I guess
it will be event better once we merge and all that). I'm glad you
decided to go back to std vectors.

I have a comment on ShapesDocument. The member "mCollections" could
actually be a simple static array rather than a std::vector, since we'll
always deal with 32 collection slots.

Also in ShapesDocument::SaveObject(), you say
   ShapesCollection    coll = mCollections[i];
but it should be a pointer I guess.

I think that ShapesLoaders classes could all go inside ShapesElements.
That would be the "master" file for the shapes editor. What about this?

That's all for now.

Tito
-- 
Physics is reverse engineering