From: tiennou <tie...@gm...> - 2007-02-28 08:13:34
|
Hi ! I need to have a talk with you about those damn accessors, and the way I write code... Are you satisfied with my naming conventions of the code I revamped ? Using mKeypointObscured as a member name and KeypointObscured() and SetKeypointObscured() as methods ? I'm trying to get ShapesEditor to work again, and as they are numerous references to the old Shapes.h structs, I'm thinking about making all members public, because it would make it work with no change. On the other hand this would mean that my accessor stuff is useless, so I'm wondering ;-) I'm thinking about refactoring code from View/Browser, because there is numerous methods related to turning ShapesFrame/ShapesBitmap into images/thumbnails for viewing. I added these capabilities to ShapesBitmap (you can now call ShapeBitmapToImage and ImageThumbnail directly on them), but I need to add a pointer to a ShapesChunk in ShapesFrame in order to be able to access the associated ShapeBitmap- >ShapeBitmapToImage call... What do you think about it ? tiennou |