Re: [Shapefusion-devel] comments

[tiennou <tie...@gm...>]

Le 26 f=C3=A9vr. 07 =C3=A0 16:00, ti...@da... a =C3=A9crit :

> Hi, great job with the wxDoc branch. I have some comments...
>
> I think the Shapes stuff is becoming really complicated with
> respect to the old implementation. I wonder if all those
> separate classes like ShapesColor are really necessary...
> Since we aren't going to extend their functionalities with
> new features, I'd prefer keeping the code as compact as
> possible rather than spreading it over too many files. If
> there was a thing I liked about the previous implementation,
> it was the very fact that all Shapes related code was kept
> inside the class Shapes, which was independent from
> wxWidgets :-) Also, I think that the Files subdirectory
> could be dropped and everything could be kept in the Shapes
> one.

As you wish ;-) I will recompress everything when I think there won't =20=

be anything big going in there...

> Since your commit fixing the Xcode project, I can't build on
> OS X anymore. I seem to lack wx.framework or something like
> that... How can I fix this? I'm using a rather old version
> of wxWidgets, will it work by just upgrading?

This is because I've built my own framework for use with ShapeFusion, =20=

which is not available right now...
I can send it to you, but the debug version I use is quite big =20
(500Mb). And as I needed room, I deleted my wxWidget source tree, =20
which means I cannot rebuild it now...
I will look into this as soon as I finish this. It shouldn't be a big =20=

problem of making it work with the current wx source tree.

> I've checked out the wxDoc branch and will examine it more
> carefully, and willy try to correct the Linux makefile.

I just (almost) completed loading/saving, now ShapeFusion 0.3 is able =20=

to read the files I save with my branch version. One bad point =20
though, frames are not displayed, there is the red X instead, so =20
there is obviously something wrong... I'm currently rewriting =20
accessors for Insert/Delete, so I can move to upgrading your View/=20
Browser widgets...

I'm glad there is not much left to do to make this (almost) final ;-).

tiennou