From: <ti...@da...> - 2007-02-26 15:01:17
|
Hi, great job with the wxDoc branch. I have some comments... I think the Shapes stuff is becoming really complicated with respect to the old implementation. I wonder if all those separate classes like ShapesColor are really necessary... Since we aren't going to extend their functionalities with new features, I'd prefer keeping the code as compact as possible rather than spreading it over too many files. If there was a thing I liked about the previous implementation, it was the very fact that all Shapes related code was kept inside the class Shapes, which was independent from wxWidgets :-) Also, I think that the Files subdirectory could be dropped and everything could be kept in the Shapes one. Since your commit fixing the Xcode project, I can't build on OS X anymore. I seem to lack wx.framework or something like that... How can I fix this? I'm using a rather old version of wxWidgets, will it work by just upgrading? I've checked out the wxDoc branch and will examine it more carefully, and willy try to correct the Linux makefile. Bye Tito |