#8 Unable to send regular DCCs...

closed-fixed
None
5
2002-01-27
2002-01-27
No

Unable to send regular DCC's. however sending
DCC's in "reverse mode" works fine.

Discussion

  • Michael Ledford

    Michael Ledford - 2002-01-27
    • assigned_to: mledford --> dshadow
    • status: open --> open-fixed
     
  • Michael Ledford

    Michael Ledford - 2002-01-27

    Logged In: YES
    user_id=51452

    Seems there is a logic error in the code. It can be fixed
    in two discrete locations. I will present where I fixed it
    and then issue an alternative fix.

    In DCC.c on ~line 921 the logical operator "!" in front of
    the ConnNewPassiveBlankListener(cc) assumes that
    it will return NULL if there is no problems in the called
    code. This is however not the case. Therefore we
    remove the logical operator.

    Second fix... Since the expected return is 0 with no
    errors it is possible to modify the underlying code so
    that is the behavior that is done. I'm not sure where
    else this code might be called therefore I'm leaving it
    as an author decision on the final implimention. No
    diffs included as the split decision that could be made.

    I will note that this is the only current location that
    ConnNewPassiveBlankListener() is currently made.

     
  • John Bafford

    John Bafford - 2002-01-27

    Logged In: YES
    user_id=50276

    Fix applied: removing ! in dcc.c ~line 921.

     
  • John Bafford

    John Bafford - 2002-01-27
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks