Re: [sfWiki-devel] Sunday, May 14 code drop

[Todd L. M. <tm...@ha...>]

> Yes. works great. And the auto linking is great.  As a first code 
> drop it looks fantastic.  I'd clean up the code (if needed), put your 
> license notices where appropriate, and drop it!

	I will definitely do this before I lose my high-speed netlink this
Sunday.  (Won't get it back for another two or three weeks.)

> However, it is lacking ?all? wiki markup rendering...  I think you 
> should put a temporary warning in the edit form (where you have 
> "editing topicname") that says that wiki markups except WikiName 
> autolinking is not implemented yet... wiki savvy users will do edits 
> and think its broken.

	Done.  Let me know if there's a better way to word it.

> I also notice the edit page drops the common header/footer stuff.  
> Is that intentional?

	*cough*  Of course.  I never make stupid coding errors! :) 

> I'd also add a "cancel" button on the edit page that redirects to the 
> page view for that page without edits.  (we can use the action later 
> to drop page locks if we ever do page locking... currently we 
> (JOSWiki) just leave the locks dangling and rely on lock timeouts 
> which seems like a sad solution).  Perhaps this is a feature 
> request that should wait until after the code drop...

	I think I'll sit on it, for now.  The most pressing thing before
release is to run up and admin page with the edit links for the
[format-*-*] stuff, because the view.php3 doesn't work too well on them
anymore :)  Three other quickies -- add a <<phpcgi>> constant to the
admin.php3 script and edit.inc (how the pre-rendering is done); figure out
why the footer changing doesn't seem to generate a re-render; and look
into ALTERing tables that we're told to store into but aren't the right
type (e.g. old sfWiki installs).
 
> It's your form for the "goto" box. Move your <form> tags outside the 
> table tag for the header table.  forms always get an extra "border" 
> around them which is giving you the extra space...

	Okay, thanks, I fixed this.  Looks much better now.  Also
discovered that headers do wacky things to the baseline, so I moved to
bold +2 font, and got better vertical alignment.

-_Quinn