Menu

#317 Fix lzmasdk build on some bigendian arches

None
open-accepted
nobody
None
5
2017-09-04
2017-09-04
Iain Lane
No

This patch is by Florian Weimer. I grabbed it from Fedora, but it applies upstream too.

On some big-endian arches (where MY_CPU_NAME doesn't get set), there is a preprocessor syntax error. It results in build failures like this:

In file included from rar/../lzmasdk/Ppmd.h:8:0,
                 from rar/../lzmasdk/Ppmd7.h:12,
                 from rar/rar.h:10,
                 from rar/rar.c:4:
rar/../lzmasdk/CpuArch.h:177:18: error: #elif with no expression
   #elif MY_CPU_BE
                  ^
In file included from rar/../lzmasdk/Ppmd.h:8:0,
                 from rar/../lzmasdk/Ppmd7.h:12,
                 from rar/rar.h:10,
                 from rar/uncompress-rar.c:7:
rar/../lzmasdk/CpuArch.h:177:18: error: #elif with no expression
   #elif MY_CPU_BE
                  ^

I couldn't find out how to check out the code, so this is just the patch I'm uploading into Ubuntu. The latest lzmasdk release contains the bug too.

1 Attachments

Discussion

  • Igor Pavlov

    Igor Pavlov - 2017-09-04
    • status: open --> open-accepted
    • Group: -->
     
  • Igor Pavlov

    Igor Pavlov - 2017-09-04

    I'll fix it.
    Thanks!

     
  • Igor Pavlov

    Igor Pavlov - 2017-09-04
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -This patch is by Florian Weimer <fweimer@redhat.com>. I grabbed it from Fedora, but it applies upstream too.
    +This patch is by Florian Weimer. I grabbed it from Fedora, but it applies upstream too.
    
     On some big-endian arches (where MY_CPU_NAME doesn't get set), there is a preprocessor syntax error. It results in build failures like this:
    
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.