#286 NSIS Script

[Jason Hood]

Here are some patches for the NSIS script support. All are based on the 15.14 release; apply with -p1 in the top directory. func.txt will have a fuzz warning unless you apply source.txt first; varsub.txt will have a warning if NSIS_SCRIPT is commented.

• source.txt - fixes a comment typo (Ser -> Set) and some indentation;
• tweaks.txt - general improvements:
  • allow a \ when testing IsGoodString, fixing some uninstallers;
  • better detection of /BRANDING and defaults in SetCtlColors;
  • ignore the first command when detecting the init plugin function (it may be DetailPrint);
  • ignore some doubled backslashes (e.g. $INSTDIR\\path should be path, not \path);
  • only add the comment to WriteUninstaller if the alternative is present;
• invalid.txt - ignore Invalid commands (they don't add anything useful);
• quotes.txt - improved quote handling:
  • detect which type of quote to use, rather than always using ";
  • quotes are only recognized at the start of a token, so only escape them when necessary;
  • comments are recognized within tokens, so always need to be quoted;
• func.txt - detect unused functions (if this line is unlabelled and the previous line is invalid or return) and mark them as such (e.g. func_627_unused);

• varsub.txt - implement simple variable substitution for better filenames:
  e.g. a Big Fish Games installer without script support:

  $_22_\$_23_
  $_22_\$_23_
  $_22_\$_23_
  $_22_\$_23_
  

and with:

    UnlockGame.bfg
    activation_info.xml
    pics\60x40.jpg
    pics\80x80.jpg

• build.txt - provide "silent" rules by default, add V=1 to see them.

[Igor Pavlov]

Thanks for patches.
Probably I'll try some simple fixes.
But NSIS code has low priority for me now. So I don't want to spend time for debugging NSIS code for complicated patches.