Menu

#278 Patch for Bug: #1532 Compression window can be resized to absurd sizes

None
open-rejected
None
5
2015-10-30
2015-10-29
No

Original Post: I was compressing a LZMA2 .7z archive and I resized the window to this size (see the attachment). The user is free to resized it to any size he wants, but he should be restrained to a minimal size so the presentation is not destroyed by a small window size.


I have a patch for bug #1532 and the scope of this bug turned out to be bigger than just the compression window.When I made an UML for impact analysis I found that it fixed other windows that also had the same issue (Test, Extract, Copy, and others) . It only allows the user to maximized and minimiumized the window.

7z1506-src\CPP\7zip\GuiCommon.rc line 58 :
-#define MY_MODAL_RESIZE_DIALOG_STYLE MY_MODAL_DIALOG_STYLE | WS_MINIMIZEBOX | WS_MAXIMIZEBOX | WS_SIZEBOX | WS_THICKFRAME

changed to :
+#define MY_MODAL_RESIZE_DIALOG_STYLE MY_MODAL_DIALOG_STYLE | WS_MINIMIZEBOX | WS_MAXIMIZEBOX

Attached is the graph showing the impact.

1 Attachments

Discussion

  • Patrick Merker

    Patrick Merker - 2015-10-29

    Here is the file

     
  • Igor Pavlov

    Igor Pavlov - 2015-10-30
    • status: open --> open-rejected
    • Group: -->
     

Log in to post a comment.