#2418 missing symlinks in log for Tar archive

[Peter Bulin]

When extracting Tar archive which contains symlinks, console output (using -bb1 or higher) is missing information about created symlinks. I have looked at the code in TarHandler.cpp and found commented code which looks like it should log this information, but it is commented:

        /*
        // probably we must show extracting info it callback handler instead
        if (item->IsHardLink() ||
            item->IsSymLink())
        {
          RINOK(extractCallback->PrepareOperation(askMode))
          RINOK(extractCallback->SetOperationResult(NExtract::NOperationResult::kOK))
        }
        */

[Igor Pavlov]

Now I don't remember why it was commented.
Maybe it was supposed that caller (client code) can show information instead, but it was not implemented by some reason.

[Peter Bulin]

So if this is uncommented will it fix the problem? Or is there a issue with this code?

[Igor Pavlov]

Yes, it must work, as I suppose.

        if (item->Is_HardLink() ||
            item->Is_SymLink())
        {
          RINOK(extractCallback->PrepareOperation(askMode))
          RINOK(extractCallback->SetOperationResult(NExtract::NOperationResult::kOK))
        }