#2413 Werror sys/types.h sys/sysmacros.h

[Terrence Yellowquill-Hill]

Not sure if you want to help here, as this is a automated build as a dependency. But I figured letting you know would be better than patching it at the distro, as when compiling with werror it halts due to types.h which was changed about 4 years ago to deprecated?

[Igor Pavlov]

Thanks.
I'll change the code to this:

#if defined(__FreeBSD__) || defined(BSD) || defined(__APPLE__)
#include <sys/types.h>
#else
#include <sys/sysmacros.h>
#endif

Are there any additional cases where we must include <sys/types.h> instead of <sys/sysmacros.h> ?
What exact cases where major macro is not placed in sys/sysmacros.h or sys/sysmacros.h is not provided?

[Terrence Yellowquill-Hill]

I believe, at this time, that it's only gcc/g++ on Linux, that requires the change to compile, the change you made, was basically how I was gonna patch it myself if I didn't hear back. I believe all the other platforms still use types.h

Sent from Proton Mail mobile

-------- Original Message --------
On Sept 27, 2023, 10:05 p.m., Igor Pavlov wrote:

Thanks.
I'll change the code to this:

if defined(FreeBSD) || defined(BSD) || defined(APPLE)

include

<sys types.h=""></sys>

else

include

<sys sysmacros.h=""></sys>

endif

Are there any additional cases where we must include <sys types.h=""> instead of <sys sysmacros.h=""> ?
What exact cases where major macro is not placed in sys/sysmacros.h or sys/sysmacros.h is not provided?</sys></sys>

---

bugs:#2413 Werror sys/types.h sys/sysmacros.h

Status: open
Group:
Created: Wed Sep 27, 2023 08:41 PM UTC by Terrence Yellowquill-Hill
Last Updated: Wed Sep 27, 2023 08:41 PM UTC
Owner: nobody
Attachments:

• 17.log (36.2 kB; application/octet-stream)

Not sure if you want to help here, as this is a automated build as a dependency. But I figured letting you know would be better than patching it at the distro, as when compiling with werror it halts due to types.h which was changed about 4 years ago to deprecated?

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/sevenzip/bugs/2413/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

[Terrence Yellowquill-Hill]

More info https://bugzilla.redhat.com/show_bug.cgi?id=130601#c6, The only thing I would check is that, there is not code that requires including types.h in the first place, as that won't be made available to the builds going forward on linux, with the suggested change. the major and minor defs do reside in types.h but is there anything else...