#1327 Threads.h and Threads.m do not meet production standard

open
nobody
None
7
2012-10-23
2012-10-23
Anonymous
No

Ignoring return values from thread and locking functions is dangerous to say the least. The problem creates hard to find bugs in multithreaded programs.

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here


    Anonymous
    2012-10-23

    Threads.h

     
    Attachments
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here


    Anonymous
    2012-10-23

    • priority: 5 --> 7
     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here


    Anonymous
    2012-10-23

    Threads.m

     
    Attachments
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here


    Anonymous
    2012-10-23

    We were going to begin to harden Threads.h and Threads.m, but I decided to yank the library due to the concerns.

    Attached are the partial hardening applied to Threads.h and Threads.m.

     
  • Igor Pavlov
    Igor Pavlov
    2012-10-23

    That code is not for Windows.
    I suppose you should post patches to p7zip project tracker instead.