Man page delivered in a wrong directory
Brought to you by:
tytso
Menu
▾
▴
#3 Man page delivered in a wrong directory
The Makefile tries to install the man page into:
$(INSTALL_DATA) setserial.8 $(DESTDIR)/usr/man/man8
This can be ok if DESTDIR is set to "/", but it's wrong
in other cases.
As a comparison, setserial binary is delivered under:
$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
I attached a patch with a fix.
Discussion
patch to fix the bug
Logged In: YES
user_id=700029
But this makes it even worse. After your patch if DESTDIR is
set to root, make install will try to put manpage to
/man/man8, which is nonsence.
Logged In: YES
user_id=773064
Indeed. The patch was a dirty hack I made for my own needs.
Sorry.
I know that's not a big deal, setserial works perfectly. I
only wanted to point out a small issue mostly faced by
package maintainers because of the hardcoded path for the
man page installation.
Anyway, I'm providing a new patch, which makes use of
@bindir@ and @mandir@ parameters from the configure script.
This way, you can "./configure --prefix=/usr/local", and
files will be installed into /usr/local, for instance.
Hope you get the general idea.
Logged In: YES
user_id=700029
Yes this is better solution :). Thanks for that. I was
actually thinking to switch to automake so that we could get
rid of manually written Makefile.in. What do you think?
Did you ever try to contact upstream maintainer? I'm in
process to takeover setserial Debian package and there is
already number of corrections, which would be worth of new
upstream release. This could be one of those.
Should we switch to public discussion forum? If you'd be
interested to discuss setserial future, I would appreciate
that :)