Re: DJGPP - Configure errors

[Thiago F.G. A. <tf...@te...>]

> > On Tue, 19 Jul 2005, Salvador Eduardo Tropea wrote:
> > 
> > > ... that in this case include/tv/nointl.h is used where:
> > > 
> > > static char       *getTextNew(const char *msgid, Boolean onlyIntl=False)
> > >                   { return onlyIntl ? NULL : newStr(msgid); };
> >                                                                ^
> > That's the problem!--------------------------------------------|
> > (sorry for those using proportional fonts :)
> > 
> > I removed this ';' after the closing bracket and it solved the problem.
> > I am sending a patch attached.
> 
> Ugh!! that's quite bizarre, a bug in the compiler? Why? The same class 
> have the same on other members ...

Yes, but this semi-colon shouldn't be there anyway: this is a definition, 
not a declaration. Think about it: if this was a "normal" function -- a 
function defined ouside the class declaration -- you wouldn't put a 
semi-colon after the body, would you? And that may explain the unresolved 
reference error: because of the semi-colon, the compiler saw this as a 
declaration, and look for the definition elsewhere. As he didn't find 
it...

And yes, all the other methods in this class are defined the same way: so 
why the compiler would give an error only with this one? The only 
explanation I can come up with is that the other methods are not used (is 
this true?), so the linker doesn't look for them.

> This is part of pathtool.cc, it seems to be missing and is only used by 
> DOS. I'm fixing it, patch attached.

Thank you. I had some difficulties applying the patch. It failed in hunk 
#2, because in my version of the file, "#include <pathtool.h> // 
IsADirectory" is in a different position. So I deleted hunk 2, applied the 
patch and then removed this line manually. Everything compiled fine.

There is a bug in the editor involving tabs. I'll start another thread to 
talk about this.

[],
Thiago

Index: infview/infbase.cc
===================================================================
RCS file: /cvsroot/setedit/setedit/infview/infbase.cc,v
retrieving revision 1.19
diff -u -r1.19 infbase.cc
--- infview/infbase.cc	19 Jul 2005 16:17:24 -0000	1.19
+++ infview/infbase.cc	27 Jul 2005 20:39:35 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1996-2003 by Salvador E. Tropea (SET),
+/* Copyright (C) 1996-2005 by Salvador E. Tropea (SET),
     see copyrigh file for details */
  /***************************************************************

@@ -41,7 +41,6 @@
  #include <fcntl.h> // open
  #include <gzfiles.h>
  #include <dyncat.h>
-#include <pathtool.h> // IsADirectory

  #ifdef TVCompf_djgpp
  #include <crt0.h>
@@ -1478,6 +1477,12 @@
  }

  static
+int IsADirectory(const char *name)
+{
+ return !access(name,D_OK);
+}
+
+static
  void GuessInfoPath(DynStrCatStruct *InfoPath)
  {
   char *djgpp=getenv("DJDIR");


-- 
()  ascii ribbon campaign - against html mail 
/\                        - against microsoft attachments