Re: [sendpage-devel] SoC Status Report for Week 1+

[Kees C. <sen...@ou...>]

On Sat, Jun 17, 2006 at 04:41:38PM +0800, Zak B. Elep wrote:
> That's what I did first actually; grab a working copy from anoncvs, then
> read and make changes in it.  It just so happened that my preferred
> editor also had the convenience of being able to store working copies to
> to version control systems simultaneously, so I can make incremental
> changes with log notes on each change.

Ah-ha!  Yeah, that's a good idea.

> Much of my latest changes has been on getting the existing variables
> properly localized, removing spurious variables (or at least commenting
> them out) and revising oft-used constructs to their clearer Perl
> equivalents (i.e. if(!defined(foo)) becomes unless(defined(foo)) or even
> unless(foo).)  This is the first pass; the next would be to plow through
> the algorithms themselves and simplify them.

I can't wait to see the first patch bundle.  :)

> Yeah, I isolated the locking code in a test program a while ago and
> found its usefulness; indeed Perl's flock() mechanism isn't strong
> enough to ram up with pppd and friends :P Still, I think we could put in
> some flock() magic in the locking code to avoid some redundancy when
> multiple calls to lock are performed (AIUIC a nonblocking flock() would
> stop locks sooner, or at least allow us to have some better `while you
> wait' code up...)

I added a perl test directory ("t") to the CVS tree too.  I figure I'll 
start writing more and more tests as the modules get worked on.  The 
locking would be a good one to test.  That's nice and stand-alone.  :)

-- 
Kees Cook                                            @outflux.net