Markus, Fabian, and gentlemen:
In building the SMW_DV_Time.php function, I noticed that you declared
certain arrays as protected, because string constants and array
constants are not supported.
This is correct as far as it goes. But when you have a string variable
or array whose contents are initialized with the class and never change,
you shouldn't need to re-initialize them every time you create an
object. And you don't.
Instead of declaring them to be merely "protected" or even "private,"
why not also declare them /static/?
That I have done, and tested them with good results.
The enclosed patch changes all protected but unchanging arrays to
/private static/ arrays, and changes their identifiers from $this->m_x
to self::$m_x wherever they appear.
Get latest updates about Open Source Projects, Conferences and News.