[Selinux-commits] SF.net SVN: selinux: [2576] trunk/libselinux/src/avc_internal.c

[<ssm...@us...>]

Revision: 2576
          http://selinux.svn.sourceforge.net/selinux/?rev=2576&view=rev
Author:   ssmalley
Date:     2007-09-24 09:11:49 -0700 (Mon, 24 Sep 2007)

Log Message:
-----------
Author: Daniel J Walsh
Email: dw...@re...
Subject: Old libselinux bug. We are leaking a file descriptor.
Date: Mon, 24 Sep 2007 11:41:29 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This bug causes dbus to leak file descriptors when autostarting confined
applications.

Should be able to remove

	ifdef(`hide_broken_symptoms', `
		dontaudit $2 $1_dbusd_t:netlink_selinux_socket { read write };
	');

- From policy.

Modified Paths:
--------------
    trunk/libselinux/src/avc_internal.c

Modified: trunk/libselinux/src/avc_internal.c
===================================================================
--- trunk/libselinux/src/avc_internal.c	2007-09-19 21:17:29 UTC (rev 2575)
+++ trunk/libselinux/src/avc_internal.c	2007-09-24 16:11:49 UTC (rev 2576)
@@ -61,7 +61,8 @@
 		rc = fd;
 		goto out;
 	}
-
+	
+	fcntl(fd, F_SETFD, FD_CLOEXEC);
 	if (!blocking && fcntl(fd, F_SETFL, O_NONBLOCK)) {
 		close(fd);
 		rc = -1;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.