[Selinux-commits] SF.net SVN: selinux: [2752] trunk/libsemanage/src/genhomedircon.c

[<ssm...@us...>]

Revision: 2752
          http://selinux.svn.sourceforge.net/selinux/?rev=2752&view=rev
Author:   ssmalley
Date:     2008-01-24 12:15:58 -0800 (Thu, 24 Jan 2008)

Log Message:
-----------
Author: Caleb Case
Email: cc...@tr...
Subject: libsemanage: genhomedircon remove error on missing HOME_DIR or HOME_ROOT
Date: Wed, 23 Jan 2008 08:53:56 -0500

Removing failure condition in write_context_file when HOME_DIR or
HOME_ROOT are not found in the contexts. This condition is not needed
(the case where the lists are empty is handled correctly) and stops
otherwise valid operations:

On a fresh policy store, without any modules loaded:

# semodule -s refpolicy -b /usr/share/selinux/refpolicy/base.pp
libsemanage.semanage_install_sandbox: semanage_genhomedircon returned
error code -1. No such file or directory.
semodule:  Failed!

Modified Paths:
--------------
    trunk/libsemanage/src/genhomedircon.c

Modified: trunk/libsemanage/src/genhomedircon.c
===================================================================
--- trunk/libsemanage/src/genhomedircon.c	2008-01-24 19:27:50 UTC (rev 2751)
+++ trunk/libsemanage/src/genhomedircon.c	2008-01-24 20:15:58 UTC (rev 2752)
@@ -792,10 +792,6 @@
 	homedir_context_tpl = make_template(s, &HOME_DIR_PRED);
 	homeroot_context_tpl = make_template(s, &HOME_ROOT_PRED);
 	user_context_tpl = make_template(s, &USER_CONTEXT_PRED);
-	if (!homedir_context_tpl || !homeroot_context_tpl) {
-		retval = STATUS_ERR;
-		goto done;
-	}
 
 	if (setup_fallback_user(s) != 0) {
 		retval = STATUS_ERR;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.