Franky Van Liedekerke - 2016-03-03

Hi,

in the file "op/op.Login.php", lines 153 and following, there is a double code part for ldap bind/auth. I changed it to be like this:

                /* Now do the actual authentication of the user */
                $bind = @ldap_bind($ds, $dn, $pwd);
                if ($bind) {
                        // Successfully authenticated. Now check to see if the user exists within
                        // the database. If not, add them in if _restricted is not set,
                        // but do not add their password.
                        $user = $dms->getUserByLogin($login);
                        if (is_bool($user) && !$settings->_restricted) {
                                // Retrieve the user's LDAP information.
                                if (isset($settings->_ldapFilter) && strlen($settings->_ldapFilter) > 0) {
                                        $search = ldap_search($ds, $settings->_ldapBaseDN, "(&(".$ldapSearchAttribut.$login.")".$settings->_ldapFilter.")");
                                } else {
                                        $search = ldap_search($ds, $settings->_ldapBaseDN, $ldapSearchAttribut . $login);
                                }

                                if (!is_bool($search)) {
                                        $info = ldap_get_entries($ds, $search);
                                        if (!is_bool($info) && $info["count"]==1 && $info[0]["count"]>0) {
                                                $user = $dms->addUser($login, null, $info[0]['cn'][0], $info[0]['mail'][0], $settings->_language, $settings->_theme, "");
                                        }
                                }
                        }
                        if (!is_bool($user)) {
                                $userid = $user->getID();
                        }
                }
                ldap_close($ds);

Hope this helps :-)

Also, it would be nice to mention in the readme that at least sqlite 3.8 is needed (otherwise the indexing doesn't work).