From: PEdroArthur_JEdi <ped...@gm...> - 2008-11-12 14:13:48
|
On Wed, Nov 12, 2008 at 10:47 AM, Paulo Cezar <pc...@gm...> wrote: > Although, I am ready to start programming through it, however, that project > has been done for Richardson only, it sounds like fine :-) What did you mean? That Richardson himself did the coding process? No, most of the code was write by the Hogwash team, lead by Jason Larsen, and the some more code writing was done by the HLBR team, lead by Eriberto Mota and Andre Bertelli. The SF project is growing through the HLBR code. > I was looking for through the its source code, I got see his code is with > several #ifdef, thus leaving the code a little bad for reading it, we could > to get eliminating them, The use of macro preprocessing is justified by the perfformace gain. It removes all the code that can't be used by a OS. Like the #ifdef LINUX ... #endif, we just don't want the packets been verified against a solaris packet type, cause at linux doesn't exists solaris packet type. Other use is for debug. We, the HLBR team, don't think that would be cost-effective having a -b cl option to have debug output enable and having to do something like if (debug) { /* Some code */ } all along the source code. That was our design decision. But the SF team may think different, so your points may be plausible. Besides, having a preprocessor debug flag is more effective cause we may have just a code portion debbuged. Welcome, and that the force be with you! -- PEdroArthur_JEdi Nunca acredite num sistema que você não conhece o código fonte! Never trust a system you don't have sources for! |