#1 LIBSDL_GFX_DLL_IMPORT should be tested before DLL_EXPORT

closed
nobody
None
5
2010-08-17
2010-05-08
Anonymous
No

LIBSDL_GFX_DLL_IMPORT should be first tested before DLL_EXPORT, as this will cause issues when linking against sdl_gfx in a third party DLL that also defines DLL_EXPORT.

Discussion

  • ferzkopp

    ferzkopp - 2010-07-20

    Contributor: pease provide .patch or repro steps.

     
  • Tiger Tiger

    Tiger Tiger - 2010-08-15

    Index: SDL_framerate.h

    --- SDL_framerate.h (revision 35)
    +++ SDL_framerate.h (working copy)
    @@ -49,7 +49,7 @@
    /* --------- Function prototypes */

    #ifdef WIN32
    -# ifdef DLL_EXPORT
    +# if defined( DLL_EXPORT ) && !defined( LIBSDL_GFX_DLL_IMPORT )
    # define SDL_FRAMERATE_SCOPE __declspec(dllexport)
    # else
    # ifdef LIBSDL_GFX_DLL_IMPORT
    Index: SDL_gfxBlitFunc.h
    ===================================================================
    --- SDL_gfxBlitFunc.h (revision 35)
    +++ SDL_gfxBlitFunc.h (working copy)
    @@ -23,7 +23,7 @@
    /* -------- Prototypes */

    #ifdef WIN32
    -# ifdef DLL_EXPORT
    +# if defined( DLL_EXPORT ) && !defined( LIBSDL_GFX_DLL_IMPORT )
    # define SDL_GFXBLITFUNC_SCOPE __declspec(dllexport)
    # else
    # ifdef LIBSDL_GFX_DLL_IMPORT
    Index: SDL_gfxPrimitives.h
    ===================================================================
    --- SDL_gfxPrimitives.h (revision 35)
    +++ SDL_gfxPrimitives.h (working copy)
    @@ -30,7 +30,7 @@
    /* ----- W32 DLL interface */

    #ifdef WIN32
    -# ifdef DLL_EXPORT
    +# if defined( DLL_EXPORT ) && !defined( LIBSDL_GFX_DLL_IMPORT )
    # define SDL_GFXPRIMITIVES_SCOPE __declspec(dllexport)
    # else
    # ifdef LIBSDL_GFX_DLL_IMPORT
    Index: SDL_imageFilter.h
    ===================================================================
    --- SDL_imageFilter.h (revision 35)
    +++ SDL_imageFilter.h (working copy)
    @@ -18,7 +18,7 @@
    /* ------ Function Prototypes ------ */

    #ifdef WIN32
    -# ifdef DLL_EXPORT
    +# if defined( DLL_EXPORT ) && !defined( LIBSDL_GFX_DLL_IMPORT )
    # define SDL_IMAGEFILTER_SCOPE __declspec(dllexport)
    # else
    # ifdef LIBSDL_GFX_DLL_IMPORT
    Index: SDL_rotozoom.h
    ===================================================================
    --- SDL_rotozoom.h (revision 35)
    +++ SDL_rotozoom.h (working copy)
    @@ -38,7 +38,7 @@
    /* ---- Prototypes */

    #ifdef WIN32
    -# ifdef DLL_EXPORT
    +# if defined( DLL_EXPORT ) && !defined( LIBSDL_GFX_DLL_IMPORT )
    # define SDL_ROTOZOOM_SCOPE __declspec(dllexport)
    # else
    # ifdef LIBSDL_GFX_DLL_IMPORT

     
  • ferzkopp

    ferzkopp - 2010-08-17
    • status: open --> closed
     
  • ferzkopp

    ferzkopp - 2010-08-17

    Fixed in rev. 38

     

Log in to post a comment.