#98 patch for as-z80 and link-z80 to generate cdb

closed-accepted
None
5
2008-02-16
2008-02-14
Armin Diehl
No

a simple patch to allow generation of cdb debug info for as-z80 and link-z80 using the existing code from the 8051 asm and linker.

Discussion

  • Armin Diehl

    Armin Diehl - 2008-02-14

    Logged In: YES
    user_id=295209
    Originator: YES

    File Added: sdcc-aslinkz80-cdb.patch.gz

     
  • Borut Ražem

    Borut Ražem - 2008-02-16

    Logged In: YES
    user_id=568035
    Originator: NO

    Armin,

    thank you very much for the patch.

    I have few comments / quiestions:

    - you used the -y to produce SDCdb debug as file[cdb], but this option is already used for some other purpose from gbz80; in other hand hc80 and mcs51 use the -z option, which is already used on gbz80. I propose to use the -z option to produce SDCdb debug as file[cdb] (so it will be unified for all targets) and to use -Z option to produce Gamegear image as file[GG] and/or Gameboy image as file[GB].

    - I compared mcs51/lkmain.c and z80/lkmain.c and I saw that you didn't include the lines starting with the comment /* pass any "magic comments" to NoICE output */ and you didn't implement the stuff connected with jflag and jfp to control NoICE output file generation. I'm not a z80 expert so please enlighten me.

    Borut

     
  • Maarten Brock

    Maarten Brock - 2008-02-16

    Logged In: YES
    user_id=888171
    Originator: NO

    Armin and Borut,

    I also looked at it and came to the same conclusion: Don't use -y but instead -z. And use -Z for the binary output.

    I also propose to move noice.c to as/asxxsrc/

    Finally I don't understand what noice has to do with sdcdb. Aren't they totally unrelated?

    Maarten

     
  • Borut Ražem

    Borut Ražem - 2008-02-16

    Logged In: YES
    user_id=568035
    Originator: NO

    Hi Maarten,

    it seems that we both worked on Armin's patch and came to similar conclusion. I already moved noice.c to as/asxxsrc/ on my local snapshot ;-)

    I asked about noice just because the newly included file is noice.c, so I thought they might be related. But the question about /* pass any "magic comments" to
    NoICE output */ still remains...

    Maarten, we have to decide who will commit the patch. I'm ready, just waiting to clarify the open issue...

    Borut

     
  • Borut Ražem

    Borut Ražem - 2008-02-16
    • assigned_to: nobody --> borutr
     
  • Borut Ražem

    Borut Ražem - 2008-02-16

    Logged In: YES
    user_id=568035
    Originator: NO

    Marteen,

    in the mean time I found out that also /* pass any "magic comments" to NoICE output */ has nothing to do with sdcdb.

    I'll commit the patch if it is OK wit you.

    Borut

     
  • Maarten Brock

    Maarten Brock - 2008-02-16

    Logged In: YES
    user_id=888171
    Originator: NO

    That's fine, just go ahead.

     
  • Borut Ražem

    Borut Ražem - 2008-02-16

    Logged In: YES
    user_id=568035
    Originator: NO

    Patch applied in svn revision #5011.

    Borut

     
  • Borut Ražem

    Borut Ražem - 2008-02-16
    • status: open --> closed-accepted
     
  • Maarten Brock

    Maarten Brock - 2008-02-16

    Logged In: YES
    user_id=888171
    Originator: NO

    I've added some extra's in #5013 like using the new and changed options from SDCC.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks