Menu

#474 Patches for MSVC2022 (and other compilers)

None
open
nobody
msvc-patch (1)
5
2024-09-09
2024-04-03
Ger Hobbelt
No

These popped up (and got fixed) while compiling SDCC with latest MSVC2022, using the (upgraded) MSVC solution file (which update will be another patch ticket)

Much easier to use git, but alas. Here's the git repo branch that carries these patches against latest trunk (as obtained from the SourceForge "experimental mirror (Git)": https://github.com/GerHobbelt/sdcc/commits/MSVC2022-fixes/

Patches wre created using

  git format-patch --pretty=email --stat -m --first-parent  original-trunk..HEAD

and can be applied using git am / git apply

Each patch is a small change and comes with commit message describing the change.

However, I find it's much easier to review this sort of stuff on github or with git-oriented tools (TortoiseGit + Beyond Compare); but to each their own poison toolkit. ;-)

HTH

7 Attachments

Discussion

  • Philipp Klaus Krause

    Regarding patch 0007: AFAIK, this is a file from upstream GCC. Maybe upstream has already fixed this, and we can just user their version, to keep the diff to upstream GCC small? @felixs?

     
  • Philipp Klaus Krause

    Regarding patch 0003: yes, those old-style declaration should go away, but this is a file from upstream asxxxx. Has upstream fixed this issue, so we can just use their solution to keep the diff small?

     
  • Philipp Klaus Krause

    Regarding patch 0001: this is a file from upstream GNU binutils. Has upstream fixed this issue, so we can just use their solution to keep the diff small?

     
  • Philipp Klaus Krause

    • Group: -->
     
  • Philipp Klaus Krause

    Regarding patch 0005: the variable last_life will only be read if num_life is nonzero, and in that case it will have a value assigned. So any warning about a read of an uninitialized variable here would be a false positive.

     
  • Philipp Klaus Krause

    Patches 0002, 0004 and 0006 are now in svn trunk: [r14990].

     

    Related

    Commit: [r14990]


Log in to post a comment.