#46 Oki 80C154S register definition

closed-accepted
None
5
2005-07-29
2005-07-28
No

Hello,

here is a complete register and chip definition header
file for SDCC for Oki MSM80C154S and MSM83C154S
controllers.
I hope this fits, I tried to follow the SDCC standard
closely. when doing it this morning.

HTH,
Matthias

Discussion

  • Matthias Arndt

    Matthias Arndt - 2005-07-28

    Oki 80C154S register definition

     
    Attachments
  • Frieder Ferlemann

    Logged In: YES
    user_id=589052

    Some minor comments:

    - the LGPL instead of GPL licence would be more appropriate
    for a library

    - definitions with double underscore are considered more
    ANSI compliant,
    so it would be f.e. __sfr __at (0x80) P0;

    - the brackets around the address allow to use an empty define
    [like #define __at(x)] to remove MCU specific keywords.
    (helps if you should want to run another compiler over
    (part of)
    your code)

    - SDCC uses a flat name space for all mcs51 derivatives. In
    the looong
    run this doesn't scale well and might lead to name clashes.
    To avoid this please don't use "8" as first character of
    the filename, msm8..... or oki8..... would look better to me.

    Thanks,
    Frieder

     
  • Maarten Brock

    Maarten Brock - 2005-07-28

    Logged In: YES
    user_id=888171

    I will replace the license, convert to double-underscored
    keywords and rename the file to msm8xc154s.h including the
    encapsulating define (REG... becomes MSM8...)

    I will also change to bracketed addresses. Is this something
    we want to use more often? I'm all in favor of it as it brings
    something like sfr16 at (0x81, 0x82) a step closer (if only in
    one's mind).

    And after all this I will commit to cvs if noone objects.

     
  • Erik Petrich

    Erik Petrich - 2005-07-28

    Logged In: YES
    user_id=635249

    I don't think the GPL allows pasting a new license in its
    place. Although I agree the LGPL would be better, Matthias
    would need to approve this change in licensing terms for it
    to be proper.

     
  • Matthias Arndt

    Matthias Arndt - 2005-07-29

    Logged In: YES
    user_id=584841

    Ofcourse do any changes to the file you think to be needed.
    Rename, restyle, relicense, whatever needed.

    Actually I took a look at the 8052.h file and styled mine in
    the same way, e.q. the comment block was simply cut'n'paste
    into the editor.
    I'm glad to contribute in some way :)

    cheers,
    Matthias

     
  • Maarten Brock

    Maarten Brock - 2005-07-29
    • assigned_to: nobody --> maartenbrock
    • status: open --> closed-accepted
     
  • Maarten Brock

    Maarten Brock - 2005-07-29

    Logged In: YES
    user_id=888171

    Erik,
    Yes I know. But I was trying to provoke an answer from
    Matthias.

    Matthias,
    Thank you very much.

    I will commit later this evening or tomorrow.

    Maarten

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks