Small Device C Compiler (SDCC) / Patches / #401 Makebin: reduce complexity of noi2sym code

The Small Device C Compiler (SDCC), targeting 8-bit architectures

#401 Makebin: reduce complexity of noi2sym code

Milestone: None

Status: open

Owner: nobody

Labels: makebin (2)

Priority: 5

Updated: 2022-03-06

Created: 2021-11-05

Creator: bbbbbr

Private: No

Per discussion in patch [#400] here is an attempt to simplify the processing code in noi2sym() inside makebin. The goal is to make the function more compact and easier to maintain.

These changes aren't strictly necessary, so no worries if the decision is to not merge them.

1 Attachments

makebin_noi2sym_simplify.patch

Sebastian Riedel - 2022-03-05

I haven’t fully read through it, but looks good on first sight. But I haven’t fully read through the main part yet.

I originally used getline and broke Windows compatibility. Since 4.1.0 was about to be released, I quickly fixed this with first alternative that showed up in my searches.

Note to myself: compare with string parser from pre-[r12064]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -1,4 +1,4 @@
-Per discussion in patch 400 here is an attempt to simplify the processing code in `noi2sym()` inside `makebin`. The goal is to make the function more compact and easier to maintain.
+Per discussion in patch [#400] here is an attempt to simplify the processing code in `noi2sym()` inside `makebin`. The goal is to make the function more compact and easier to maintain.

 These changes aren&#39;t strictly necessary, so no worries if the decision is to not merge them.

Group: -->

Patches: ~~#400~~

Makebin: reduce complexity of noi2sym code

The Small Device C Compiler (SDCC), targeting 8-bit architectures

Group

Searches

Help

#401 Makebin: reduce complexity of noi2sym code

Related

Discussion

Related