#226 Two defects in genIfx of stm8/gen.c

None
closed-accepted
None
5
2014-03-29
2014-02-26
Ben Shi
No

two tiny potential bugs

1 Attachments

Discussion

  • Philipp Klaus Krause

    Thanks. Both are good catches: The first is a bug that might result in wrong code being generated.
    The second one is more subtle: I still remember, when I wrote that code, I thought that ld a, yl, is twice as expensive as exg a, yl, so I could just fall through to the exg case below without losing anything. But I only thought of code size. In terms of speed, the ld a, yl is actually faster by one cycle than the double exg a, yl.

    Applied in revision #8954.

    Philipp

     
  • Philipp Klaus Krause

    • status: open --> closed-accepted
    • assigned_to: Philipp Klaus Krause
    • Group: -->
     
  • Maarten Brock

    Maarten Brock - 2014-02-28

    Reverted because something got broken.

     
  • Maarten Brock

    Maarten Brock - 2014-02-28
    • status: closed-accepted --> open
     
  • Philipp Klaus Krause

    I'll have another look at this after the 3.4.0 release.

    Philipp

     
  • Ben Shi

    Ben Shi - 2014-03-06

    I have done regression test for stm8 on both rev8954 and rev8955 locally, it seemed that rev8954 passed but rev8955 got 4 failures. So should this patch (8953 -> 8954) itself be OK ?

     
  • Philipp Klaus Krause

    I applied the patch in the sdcc-stm8 branch, which I created for changes to the stm8 backend. The branch can be merged after the 3.4.0 release.

    You can find the sdcc-stm8 branch using:
    svn co https://svn.code.sf.net/p/sdcc/code/branches/sdcc-stm8/sdcc sdcc-stm8

    Philipp

     
  • Philipp Klaus Krause

    • status: open --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks