#168 PIC16: Acq. time is also available in 18f2220 style of ADC

closed-accepted
nobody
None
5
2011-10-16
2011-09-14
No

Acquisition time is also available in 18f2220 style of ADC, i.e. 18f2550.

Modifications:
sdcc/device/include/pic16/adc.h
- 18f2220 style added in acquisition time comment
- ADCON2bits described for 18f2220 style

sdcc/device/lib/pic16/libio/adc/adcopen.c
- ADCON2 assignation now uses acquisition time info from fosc instead of leaving ACQTx bits unmodified

Please, could anybody check if I'm right and this is correct?

Thank you very much

Discussion

  • Diego Herranz

    Diego Herranz - 2011-09-14
     
  • Diego Herranz

    Diego Herranz - 2011-09-16

    I've compiled sdcc 3.0.0 with this changes and it worked for me.

    I've also tried with last code on svn but when I compile a PIC16 example (one that works) I get an error saying it can't find crt0. Even without my modifications it doesn't work. Maybe I'm not compiling it right.

     
  • Diego Herranz

    Diego Herranz - 2011-09-18
    • summary: Acquisition time is also available in 18f2220 style of ADC --> PIC16: Acq. time is also available in 18f2220 style of ADC
     
  • Diego Herranz

    Diego Herranz - 2011-10-16

    Any possibility to address this before 3.1.0?

    Maybe I should have posted it in bugs and not in patches, I don't know. If so, I'm sorry.

    Thank you

     
  • Raphael Neider

    Raphael Neider - 2011-10-16

    Fixed in r6972.
    Again, thank you for reporting this and for proposing improvements.

    Sending in patches is perfect when you have a solution for the problem you spotted, so you absolutely did the right thing. Probably, I would not have (been able to) respond(ed) any earlier to a bug report :-(

     
  • Raphael Neider

    Raphael Neider - 2011-10-16
    • status: open --> closed-accepted
     

Log in to post a comment.