From: Philipp K. K. <pk...@sp...> - 2013-09-04 15:58:10
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I noticed today that the pic16 port now compiles all regression tests that were not disabled for pic16 before. So, I just disabled all failing tests for pic16, and get a nice regression test result: Summary for 'pic16': 0 failures, 6353 tests, 1629 test cases, 0 bytes, 0 ticks I suggest we enable automatic regression testing for the pic16 port, to keep this annoying, broken port from breaking further too soon. Philipp P.S.: I guess that a lot of the failures are related to multiplication being broken for certain cases: Fixing the two assertion failures in the muldiv test should go a long way towards fixing other failures, too. P.P.S.: The pic14 port is still a hopeless case. I don't know if there are any tests that don't fail on pic14. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlInWIEACgkQbtUV+xsoLpqmMwCg7S6FwbL8Lxo/ydx1IiNUz4Iw elEAoODQv7fTSaGJJgwFRnW2JSNXwTBI =sQaK -----END PGP SIGNATURE----- |
From: Diego H. <die...@di...> - 2013-09-05 17:10:56
|
Please enable the regression tests, it would be a great start. On your opinion, is there any chance for this port to become more stable? What are the most important missing/broken things? Thanks a lot! On Wed, Sep 4, 2013 at 5:58 PM, Philipp Klaus Krause <pk...@sp...> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I noticed today that the pic16 port now compiles all regression tests > that were not disabled for pic16 before. So, I just disabled all > failing tests for pic16, and get a nice regression test result: > > Summary for 'pic16': 0 failures, 6353 tests, 1629 test cases, 0 bytes, > 0 ticks > > I suggest we enable automatic regression testing for the pic16 port, > to keep this annoying, broken port from breaking further too soon. > > Philipp > > P.S.: I guess that a lot of the failures are related to multiplication > being broken for certain cases: Fixing the two assertion failures in > the muldiv test should go a long way towards fixing other failures, too. > > P.P.S.: The pic14 port is still a hopeless case. I don't know if there > are any tests that don't fail on pic14. > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.14 (GNU/Linux) > Comment: Using GnuPG with Icedove - http://www.enigmail.net/ > > iEYEARECAAYFAlInWIEACgkQbtUV+xsoLpqmMwCg7S6FwbL8Lxo/ydx1IiNUz4Iw > elEAoODQv7fTSaGJJgwFRnW2JSNXwTBI > =sQaK > -----END PGP SIGNATURE----- > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk > _______________________________________________ > sdcc-devel mailing list > sdc...@li... > https://lists.sourceforge.net/lists/listinfo/sdcc-devel > |
From: Philipp K. K. <pk...@sp...> - 2013-09-05 17:55:52
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 05.09.2013 19:10, schrieb Diego Herranz: > Please enable the regression tests, it would be a great start. > > On your opinion, is there any chance for this port to become more > stable? What are the most important missing/broken things? > > Thanks a lot! Yes, I think this port has a chance to become stable. I am surprised by how well it works; it seems to be in a better shape than the gbz80 port used to be. And that one was resurrected with not too much effort. There are some missing things, but the broken things are the big issue. To be considered stable, it should at least pass all regression tests for basic functionality. These are a few important ones, that have an #ifndef __SDCC_pic16 in the code. tests/bitwise.c tests/bool.c: tests/muldiv.c tests/onebyte.c To help make sdcc more stable, remove the #ifndef __SDCC_pic16 check if they still fail with current sdcc, and if they do fix whatever bug causes the failure. Philipp -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlIoxZkACgkQbtUV+xsoLppYFgCfYsn3Cc8wr5Xvb7vRaqKDsM50 8KsAn2sfGEcPYqVi5soXvY6uWz9fSdnJ =e63j -----END PGP SIGNATURE----- |
From: Sebastien L. <seb...@lo...> - 2013-09-06 08:45:46
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Code-size wise, an huge improvement to this port would be an option to use an overlayed local variable allocator, just like the 8051 one, because at the moment, the pic16 port uses a full stack based code generator, which is rather inefficient (and very few functions really need reentrancy). But I have no time to code it, and I know it's a complex matter :( So that's just a "nice to have" item for a todo list. BR Sebastien Lorquet Le 05/09/2013 19:55, Philipp Klaus Krause a écrit : > Am 05.09.2013 19:10, schrieb Diego Herranz: > > Please enable the regression tests, it would be a great start. > > > On your opinion, is there any chance for this port to become more > > stable? What are the most important missing/broken things? > > > Thanks a lot! > > Yes, I think this port has a chance to become stable. I am surprised > by how well it works; it seems to be in a better shape than the gbz80 > port used to be. And that one was resurrected with not too much effort. > > There are some missing things, but the broken things are the big > issue. To be considered stable, it should at least pass all regression > tests for basic functionality. > > These are a few important ones, that have an > #ifndef __SDCC_pic16 > in the code. > > tests/bitwise.c > tests/bool.c: > tests/muldiv.c > tests/onebyte.c > > To help make sdcc more stable, remove the > #ifndef __SDCC_pic16 > check if they still fail with current sdcc, and if they do fix > whatever bug causes the failure. > > Philipp > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk > _______________________________________________ > sdcc-devel mailing list > sdc...@li... > https://lists.sourceforge.net/lists/listinfo/sdcc-devel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSKZI+AAoJEJFP1HbJm5DnfC0IAKJgfjC1A86S6zvYA0E++wcz lU2hSZDCDKf0sh2YZUrT33ZyJEfSYZSzxJxoTHUGNnmzulE5bqtkkOMmXTp/cXVi QZlgCrjDL5uuiaJVFasIeI+MGYa4PM1iHIS8RThGYKCHQBxgZHhzAb7XtuBfZ93C AUwKi6SsVYvRn1qUjEjaynY/svJP3n4lkuFA6blcb9ADKY5rrk1orLRYL+6Dh9iP WFkB4aIlNSktyNO5Qbho9EAgwXZxb8jmXJtJC4DoDZsaTSPS+Wl1FqrbTcBX57ZJ 0FKDrRThyMBdKMTOje3RK3LWF8Xbq5Eduqztlgacdx9UnsSgRYo86A2fjaX9I8A= =Mc5Z -----END PGP SIGNATURE----- |