From: Johan K. <joh...@id...> - 2001-11-15 18:39:11
|
Hi, please look at the ds390 .asm of _fsdiv.c at line 43. It contains some extra "inc dptr"-s that could be optimized :) and blows the float.c test. The fix should be obvious, but I don't have anymore time today. Johan |
From: Kevin V. <kv...@lu...> - 2001-11-16 03:48:42
|
On 15-Nov-2001 Johan Knol wrote: > Hi, please look at the ds390 .asm of _fsdiv.c at line 43. It contains > some > extra "inc dptr"-s that could be optimized :) and blows the float.c > test. > The fix should be obvious, but I don't have anymore time today. I'm afraid I'm not seeing a problem; perhaps someone fixed this already? Line 43 generates this code for me: ; _fsdiv.c 43 ; genPlus mov dptr,#___fsdiv_exp_1_1 ; Swapped plus args. movx a,@dptr add a,#0x7E movx @dptr,a inc dptr movx a,@dptr addc a,#0x00 movx @dptr,a ; _fsdiv.c 46 which looks like a perfectly fine bit of code to me. I didn't see any problems at all in the generated code, actually, though the right shift code is pretty ugly to say the least... Let me know if you're still seeing something. Peace, Kevin |
From: Sandeep D. <sa...@wi...> - 2001-11-16 04:31:09
|
Yes I did .. sorry I was going to send out an email Sandeep > -----Original Message----- > From: sdc...@li... > [mailto:sdc...@li...]On Behalf Of > Kevin Vigor > Sent: Thursday, November 15, 2001 7:49 PM > To: Johan Knol > Cc: sdc...@li... > Subject: RE: [sdcc-devel] ds390 fun > > > > On 15-Nov-2001 Johan Knol wrote: > > Hi, please look at the ds390 .asm of _fsdiv.c at line 43. > It contains > > some > > extra "inc dptr"-s that could be optimized :) and blows the float.c > > test. > > The fix should be obvious, but I don't have anymore time today. > > I'm afraid I'm not seeing a problem; perhaps someone fixed > this already? > > Line 43 generates this code for me: > > ; _fsdiv.c 43 > ; genPlus > mov dptr,#___fsdiv_exp_1_1 > ; Swapped plus args. > movx a,@dptr > add a,#0x7E > movx @dptr,a > inc dptr > movx a,@dptr > addc a,#0x00 > movx @dptr,a > ; _fsdiv.c 46 > > which looks like a perfectly fine bit of code to me. I didn't see any > problems at all in the generated code, actually, though the > right shift > code is pretty ugly to say the least... > > Let me know if you're still seeing something. > > Peace, > Kevin > > _______________________________________________ > sdcc-devel mailing list > sdc...@li... > https://lists.sourceforge.net/lists/listinfo/sdcc-devel > > > |