|
From: Maarten B. <sou...@ds...> - 2023-11-09 18:47:25
|
Philipp Klaus Krause schreef op 2023-11-09 10:11: > Currently, the mcs51 port uses the aop type AOP_DIR to anything > directly addressed, no matter if it is a "normal" variable or a > special function register. I have not verified this. I'm assuming you are correct. > But many functions handling stuff need to know if the thing they > handle is an sfr. So, the mcs51 port uses operand in many places where > other ports use asmop (to ensure that it is still possible to find out > if that directly addressed thingis an sfr). > > I wonder if it would be cleaner to handle this like the other ports: > Have AOP_DIR only for things in normal memory, and use AOP_SFR for the > special function registers. > > Philipp Then that might very well be. If so then they probably start out as AOP_SFR and later get changed to AOP_DIR. Maarten |