From: daniel r. <dan...@in...> - 2006-08-28 12:44:58
|
Frieder, Thank you very much for your enlighting specialist's remarks! Some of the mistakes are more or less related to the particular C dialect for which it was written (CC5X, not SDCC)... But anyway thank you much for your kind attention and patience. Daniel Frieder Ferlemann wrote: >daniel ranc schrieb: > > >>On the page http://simplepic.atspace.com you'll find a "poorman's >>printf" in source code that you could adapt for your needs (without >>varargs). >> >> > >Hi Daniel, > >some remarks: > >- an include file seems missing (INTBUFSIZE, uns8), >- putchar should (could) be in a separate file, >- int16 t could probably be 8 bit, t = (uns8)(u % (uns8)10); >- one instruction per line would help single stepping, >- intbuf need not be defined as static (on 8051 one > would/could additionally use idata/pdata), >- "%%" to output '%' is not implemented, >- eventually i++ in line 79 can be avoided if > i-- line 76 is moved up >- using code as additional attribute to the first > printf argument should give more compact code > >sorry for the critisism and thank you for the code! > >Frieder > >------------------------------------------------------------------------- >Using Tomcat but need to do more? Need to support web services, security? >Get stuff done quickly with pre-integrated technology to make your job easier >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo >http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >_______________________________________________ >Sdcc-user mailing list >Sdc...@li... >https://lists.sourceforge.net/lists/listinfo/sdcc-user > > |