Hi Maarten,

all of the modified files (configure, aclocal.m4, depcomp, Makefile.in (from Makefile.am), install-sh, missing, ltmain.sh (libtool), sdccconf_in.h (typically config.h, has the #defines detected by configure runs) are touched by the autotools. Since svn states they are modified, they had been checked in before -- I would update them if only for consistency reasons and because this state is what you tested ;-).

We should probably create some autogen.sh or so that calls the proper versions of the autotools and avoid checking in versions generated by different tools/tool versions. That would require all developers to use the same autotool versions ... may or may not work, I don't know.

Raphael

On Wed, Apr 2, 2014 at 12:25 AM, Maarten Brock <sourceforge.brock@dse.nl> wrote:
Hi Raphael,

I also get a lot of other modified files:

configure
debugger/mcs51/aclocal.m4
debugger/mcs51/configure
device/lib/pic14/aclocal.m4
device/lib/pic14/configure
device/lib/pic14/depcomp
device/lib/pic14/libm/Makefile.in
device/lib/pic14/libsdcc/enhanced-no-xinst/Makefile.in
device/lib/pic14/libsdcc/enhanced/Makefile.in
device/lib/pic14/libsdcc/regular/Makefile.in
device/lib/pic14/Makefile.in
device/lib/pic16/aclocal.m4
device/lib/pic16/configure
device/lib/pic16/depcomp
device/lib/pic16/install-sh
device/lib/pic16/libc/Makefile.in
device/lib/pic16/libio/Makefile.in
device/lib/pic16/libm/Makefile.in
device/lib/pic16/libsdcc/Makefile.in
device/lib/pic16/Makefile.in
device/lib/pic16/missing
device/lib/pic16/startup/Makefile.in
device/non-free/lib/pic14/configure
device/non-free/lib/pic16/aclocal.m4
device/non-free/lib/pic16/configure
device/non-free/lib/pic16/depcomp
device/non-free/lib/pic16/install-sh
device/non-free/lib/pic16/libdev/Makefile.in
device/non-free/lib/pic16/Makefile.in
device/non-free/lib/pic16/missing
sdccconf_in.h
sim/ucsim/aclocal.m4
sim/ucsim/configure
sim/ucsim/ltmain.sh
support/cpp/configure
support/packihx/configure

I'm especially surprised about those shell scripts.

I'm currently building and running regression tests locally for a full
build to see if at least that still works and then I will commit the
manually modified files first, followed by the regenerated files. If you
think I should leave certain files out, please say so.

Maarten

> Hi,
>
> On Tue, Apr 1, 2014 at 11:57 PM, Maarten Brock <sourceforge.brock@dse.nl>
>  wrote:
>
>> Thanks for the clarification. I'm still not sure if I need those exact
>> versions. But it seems to fail if I don't.
>>
>> After running autoreconf I have lots of modified files. Is that right
>> and
>> do I have to commit them all? As you can see, I have never done this.
>>
>
> I tend to commit the files in two separate commits: first commit the
> manually edited files (configure.in, Makefile.in or Makefile.am), then
> commit all automatically regenerated files (configure, Makefile,
> occasionally Makefile.in). The diff will typically tell you if a
> particular
> file was generated or manually edited. This is cumbersome and tedious, but
> the best I can come up with.
> The autogeerated files are typically committed with a comment such as
> "regenerated" or so.
> We commit those files so that SVN users do not need to have the autotools
> (in the proper versions) setup. Other projects do include the generated
> files in releases, but not in source control. It's probably a matter of
> taste.
>
>
>
> See e.g., my commits r8697 (manually edited or manually generated files
> (mkmk.sh)) and r868 (auto-generated files), log below.
>
>
> Raphael
>
>
>
> ------------------------------------------------------------------------
> r8698 | tecodev | 2013-05-30 21:27:39 +0200 (Thu, 30 May 2013) | 14 lines
>
> * device/lib/pic16/Makefile.in,
> * device/lib/pic16/aclocal.m4,
> * device/lib/pic16/configure,
> * device/lib/pic16/debug/Makefile.in,
> * device/lib/pic16/libc/Makefile.in,
> * device/lib/pic16/libio/Makefile.in,
> * device/lib/pic16/libm/Makefile.in,
> * device/lib/pic16/libsdcc/Makefile.in,
> * device/lib/pic16/startup/Makefile.in,
> * device/non-free/lib/pic16/Makefile.in,
> * device/non-free/lib/pic16/aclocal.m4,
> * device/non-free/lib/pic16/configure,
> * device/non-free/lib/pic16/libdev/Makefile.in: regenerated
>
> ------------------------------------------------------------------------
> r8697 | tecodev | 2013-05-30 21:25:40 +0200 (Thu, 30 May 2013) | 34 lines
>
> * device/lib/pic16/configure.ac,
> * device/non-free/lib/pic16/configure.ac: remove obsolete option
>   --enable-new-pics, use common device support detection from
>   supported-devices.ac and the generated processors.ac
> * device/non-free/lib/pic16/supported-devices.ac: fragment from
>   configure.ac performing detection of devices supported by gputils;
>   device detection also performs linking step for robustness
>
> * device/lib/pic16/libio/adc.ignore,
> * device/lib/pic16/libio/i2c.ignore,
> * device/lib/pic16/libio/usart.ignore: use full device id (18fxxxx)
>
> * device/lib/pic16/libio/mkmk.sh,
> * device/non-free/lib/pic16/libdev/mkmk.sh,
> * device/non-free/lib/pic16/libdev/testall.sh:
>   derive device list from files in non-free/lib/pic16/libdev rather
>   than the manually maintained pics.all, enclose each device in
>   ENABLE_<DEVICE> conditionals
>
> * device/non-free/lib/pic16/update.sh: script to update the build
>   system to be run whenever the set of devices supported by sdcc
>   changed; generates processor.ac and reconfigures all PIC16 libs
>
> * support/scripts/cinc2h.pl: update instructions regarding adding
>   support for new devices
>
> * device/lib/pic16/libio/Makefile.am:regenerated from mkmk.sh
> * device/non-free/lib/pic16/libdev/Makefile.am:
>   regenerated from mkmk.sh
> * device/non-free/lib/pic16/pics.all: removed (no longer used)
> * device/non-free/lib/pic16/processors.ac: added, list of automake
>   conditionals for automatic detection of devices supported by
>   gputils, generated from update.sh
> ------------------------------------------------------------------------------
> _______________________________________________
> sdcc-devel mailing list
> sdcc-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sdcc-devel
>


------------------------------------------------------------------------------
_______________________________________________
sdcc-devel mailing list
sdcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sdcc-devel