Menu

#2462 Missing automake .am files

closed
nobody
None
other
5
2016-01-28
2016-01-27
No

Hello SDCC team,

I was playing around with some Makefiles when i noticed this.

Some AM files are present such as:

"./sdcc-code/sdcc/device/lib/pic14/libm/Makefile.am"

But some are not:

"./sdcc-code/sdcc/device/lib/stm8/Makefile.am"

In most cases they are missing.

Does SDCC project use them or not? If yes, then allot of them are missing and need to be added (who ever has them). If no, the remaining should be deleted.

The problem is, should Makefile.in or Makefile.am be changed depending on the previous question.

Thanks,

/pedro

Discussion

  • Ben Shi

    Ben Shi - 2016-01-28

    I suggest you post an email to our mail list discussing such issues first, then we asset it is a bug or not. Since neither bad code is generated nor sdcc works wrongly.

    My opinion is
    1. we might need to keep some non-frequently used content, such as the avr back end as future reference.
    2. The pic library has its own configure.ac /configure while other ports have not. And the pic14/libm/Makefile.am might has relation to that. (I am not familiar with pic).

     
  • Peter Dons Tychsen

    Hi,

    I suggest you post an email to our mail list discussing such issues first, then we asset it is a bug or not
    I will try to use the list more if you prefer that :-). Other projects prefer the opposite, so that all possible bugs/problems have a context and a number from the start that can be referred to.

    Since neither bad code is generated nor sdcc works wrongly.
    Problems with build systems rarely do any of these. Also, for contributers in an FOSS project, problems with the build systems are actually worse than bugs in the product, as it makes it harder to contribute.

    OK, so the PIC stuff, boost and binutils are special.
    So you do not use ".am" files in general, and the ".in" files should be updated directly. Got it.

    You can probably close this "bug" :-).

    Thanks,

    /pedro

     
  • Ben Shi

    Ben Shi - 2016-01-28
    • status: open --> closed
     

Log in to post a comment.