#236 MT-32: Write "Memory Timbres" names to LCD

[tbcarey]

Currently, ScummVM does not write the actual names of
MT-32 'memory timbres' [custom instruments] to the LCD.
For example, in MI-2, 'Memory | glop' only shows up as
'Piano | AcouPiano1', 'Memory | leshbass' as 'Strings |
Str Sect 3', etc. Obviously, this applies to all games
that use MT-32 natively.

[tbcarey]

Logged In: YES
user_id=1103943

This may or may not be related, but I just noticed that
ScummVM does not actually write custom instruments to Timbre
Memory (as the original interpreter does), but instead uses
Timbre Temp Area for specific parts.

Timbre Memory is written via start address 08 xx 00. [where
xx = 00h - 7Eh, jumping 2 bits] Timbre Temp Area is written
by first specifying part/channel number in byte 3, then via
start address 02 00 00.

Here's the different in SysEx commands between the original
interpreter and ScummVM when writing 'glop':

F0 41 10 16 12 08 00 00 67 6C 6F 70 20 20 20 [...] - Original
F0 41 01 16 12 02 00 00 67 6C 6F 70 20 20 20 [...] - ScummVM

This may be why the LCD does not display custom instrument
names when they're being written to the module.

[Jerome Fisher]

Logged In: YES
user_id=717025

Yep, I know - I'm fairly sure that's the reason it's not
shown on the LCD. The timbre name is written correctly as
part of the timbre.

There are other reasons to switch to using timbre memory
rather than the timbre temp area. It's on my to-do list.

[Jerome Fisher]

Logged In: YES
user_id=717025

I've just checked with my real MT-32, and I see "glop" on
the LCD display. When/how are you seeing something
incorrect? I'm just pressing the button for the appropriate
part (1), and seeing the correct name.

[tbcarey]

Logged In: YES
user_id=1103943

Yes, that's after the instrument has already been written to
Timbre Temp Area. However, as it's being written, your LCD
should display a program name; it will never be Memory |
[name] (as with the original interpreters), but instead a
normal program name. Presumably this is because of the
reason I followed up with about Timbre Temp Area vs. Timbre
Memory.

[Jerome Fisher]

Logged In: YES
user_id=717025

Ah yes, I see, it briefly flashes the timbre name on program
change. We don't send a program change for custom
instruments - or at least we shouldn't - since we're not
storing the data in a patch (it goes directly to the temp
areas, as you know).

[Eugene Sandulenko]

Logged In: YES
user_id=166507

Jamieson, there recently were some changes in that aspect.
What you can say on this request?

[Max Horn]

Logged In: YES
user_id=12935

It seems both Jamieson and Kingguppy are not active anymore :-/