Menu

#7166 DRASCULA: Misleading indentation in animation.cpp

Drascula
closed-fixed
None
2
2016-07-20
2016-07-20
Sven Hesse
No

GCC 6's -Wmisleading-indentation flags the if statement in engines/drascula/animation.cpp:130 to be misleadingly indented.

Specifically, this if statement is indented as if it belonged inside the for-statement in line 119. However, due to the lack of curly braces on that for-statement, this if-statement is not within the scope of that for-statement.

Discussion

  • Thierry Crozat

    Thierry Crozat - 2016-07-20
    • status: open --> closed-fixed
    • assigned_to: Thierry Crozat
     
  • Thierry Crozat

    Thierry Crozat - 2016-07-20

    Thank you. That was an interesting one as this if statement should both belong to the for-statement started in line 119 and be outside of it :P

    In essence there was one if statement missing, which caused a slight delay when interrupting the intro animation in the first scene with Igor. This is fixed with commit abb33e5.