Menu

#7086 SCI: QFG3: Tell about Initiation in Uhura's Hut

closed-fixed
nobody
5
2016-05-22
2016-03-25
Edmund
No
  1. 1.8.0pre123-gbdec806(Feb 17 2016 05:46:25)
  2. walk into the hut on the right (Uhura's hut). Pree mouth icon on yourself and choose tell about initiation, should be 3 points awarded
  3. English
  4. original Quest for Glory Collection series (not gog and not using any patches)
  5. Win dos
  6. Thanks for looking into this
1 Attachments

Discussion

  • M. Kiewitz

    M. Kiewitz - 2016-03-26
    • summary: Tell about Initiation in Uhura's Hut --> SCI: QFG3: Tell about Initiation in Uhura's Hut
    • Group: *None --> SCI: Quest for Glory 3
     
  • M. Kiewitz

    M. Kiewitz - 2016-03-26

    Original interpreter awards points? Can you please check that? And maybe even attach an original SCI saved game too?

     
  • Edmund

    Edmund - 2016-03-26

    Original interpreter ALLEGEDLY award points and I believe the original game (on floppies) all those years ago did but that game is long gone and i am using the the original collections series on cd.

     
  • Omer Mor

    Omer Mor - 2016-04-23

    The official Quest for Glory III Hint Book has a Puzzle Point list (page 45), which does not mention these 3 points.

    The 3 points are mentioned in this FAQ, but I wouldn't say it's trustworthy.

     
  • Omer Mor

    Omer Mor - 2016-04-23

    OK, I was partially wrong:
    The official hint book state that fighters and paladins can get 3 points for telling about the initiation.
    I checked the scripts, and I found evidence for these 3 points being awarded in room #285 (Kreesha, Rakeesh and Hero sitting together) when you tell about the initiation.
    Not sure yet what triggers this dialog option.

     
  • Tomasz Grzegurzko

    Here's a few attached saves from the GOG QFG3 version running natively (dosbox).
    One is having just won the initiation for the starting point.
    One is with Kreesha/Rakeesh having won the initiation - the only dialog available is about "dispelled leopard prisoner".
    One is with Uhura in her hut and although you can tell about initiation it doesn't grant points.

     
  • Tomasz Grzegurzko

    Here's a few attached saves from the GOG QFG3 version running through ScummVM.
    The situation is the same as with the native version:
    One is having just won the initiation for the starting point.
    One is with Kreesha/Rakeesh having won the initiation - the only dialog available is about "dispelled leopard prisoner".
    One is with Uhura in her hut and although you can tell about initiation it doesn't grant points.

     
  • Omer Mor

    Omer Mor - 2016-05-19

    Thanks Tomasz for the save games.
    I was able to reproduce, investigate and come up with a possible fix.

    Script 285 (Hero sitting with Rakeesh and Kreesha) initializes an egoTell object with an array (local156) of possible messages that can be shown:
    [local156 14] = [0 -41 -76 1 -30 -77 -33 -34 -35 -36 -37 -42 -80 999]

    Later, in egoTell::showDialog() there's logic that calls Teller::showDialog() with an array of messages and booleans used to determine whether that message should be shown. All the messages in this function can be found in the local156 array, expect one: message #31 which also happens to be the missing "Tell about Initiation" message.

    I suspect the positive "1" in local156 it a typo and should've been "-31". I believe only negative values are used for real messages, and the positive 0 and 999 mark the start and end of the array.

    So using SCI Companion I replaced the "1" with "-31", compiled the script, and using your save game I was able to trigger the missing message and get the 3 points.

    I'm attaching the patched 285.SCR and 285.HEP so you could test it yourself. Simply place the files in the game folder and load the game. I suggest you load a savegame from another room, and travel to room #285, because I suspect loading a savegame from that room won't go through my patched room's initialization.

    If the patch works for you, it could be later embedded in ScummVM.

     

    Last edit: Omer Mor 2016-05-19
  • Tomasz Grzegurzko

    Thanks for the fix and detailed explanation. I checked earlier but I can't see any attachments to your post now..?

     

    Last edit: Tomasz Grzegurzko 2016-05-20
  • Omer Mor

    Omer Mor - 2016-05-20

    Maybe it violates the policy, and was removed?
    You can send me a PM with your email and I'll send it to you.

     
  • Omer Mor

    Omer Mor - 2016-05-20

    Upon further testing, I no longer believe I can simply replace the "1" with "31" as the one stands for the "Tell about Tarna" option.

     
  • Tomasz Grzegurzko

    Tested on ScummVM 1.9.0git1898-g6581bca and got awarded the 3 points for telling Kreesha/Rakeesh about it. Thanks for the fix!

     
  • Omer Mor

    Omer Mor - 2016-05-22

    Thanks for testing Tomasz!
    The version you used should have my patch built-in.
    Did you test the game with the independent script patch files I sent you or w/o them?

     
  • Tomasz Grzegurzko

    I did not apply your patches to my game; it was a vanilla GOG copy of QFG3 running through ScummVM.

     
  • Omer Mor

    Omer Mor - 2016-05-22

    Great!
    So I guess this bug could be closed now (by someone who has permission to do so...).

     
  • M. Kiewitz

    M. Kiewitz - 2016-05-22
     
  • M. Kiewitz

    M. Kiewitz - 2016-05-22

    Fixed by commit aaf8cbca0049aa9161e507a22724a56e19009695

     
  • M. Kiewitz

    M. Kiewitz - 2016-05-22
    • labels: --> Script bugs, Also occurs in the original
    • status: open --> closed-fixed