#7064 IHNM: text mistake in german version

[WindlePoons]

Two text bugs in German version in the in-game option menu:

1. text is black/dark but in DOSBox this is green/hover text red.
2. the text in the left menu box is not centered.

http://i.imgur.com/4YuPhVQ.png

IHNM (DOS/German)
ScummVM 1.9.0git738-gb12cb73 (Feb 22 2016 07:05:46)

[Torbjörn Andersson]

It looks like we have a workaround for this in engines/saga/saga.cpp, SagaEngine::KnownColor2ColorId(), but only for the Spanish version. Maybe it's enough to extend this to the German version? Probably the French as well. At least, I see the same problem with the French version from GOG.

[Eugene Sandulenko]

Yes, that would do it. Willing to help?

[Torbjörn Andersson]

I think I've fixed the bug, and cherry-picked the fix into the 1.8 branch as well. There were actually two places where it worked around the colour for the Spanish version. The other affected the colour of the status line. (Actually I found a third one, which I think has to do with the spiritual barometer, but it appears that one really is only for the Spanish version.)

[WindlePoons]

Thanks, the color mistake is fixed, but not the "(non) centered text" bug.

[Torbjörn Andersson]

Ah, I got so caught up with the text colour that I completely missed the second part. Looks like it hard-codes the text position, rather than using the text centering feature.

[WindlePoons]

ok, but i am confused. In DOSBox the text is centered. (first screenshot)

[Torbjörn Andersson]

I don't doubt that. What I meant was that ScummVM, for whatever reason, hard-codes the text positions, even thought there seems to be a flag to the text renderer telling it to center the text.

The function to get the text position is called in a number of places, though, so fixing it might take a bit of time. (I'm not looking at this at the moment, so if there are any takers... :-)