#6983 SWORD25: long saving time

[mim]

It takes 15 second to save the game (from clicking on slot to completing the save). When I play the game outside of ScummVM, saving is without any delay.

ScummVM from December 9 16.20
BS English version
WinXP SP3, Core2DuoE6750

[Strangerke]

It would be nice to fix it before the release of 1.8.0. Raising priority.

[Willem Jan Palenstijn]

Does this still happen for you?

[Willem Jan Palenstijn]

And if it does, does it happen right from the start of the game? Or only after playing some time?

[mim]

Yes, it still happens and right from the start of the game.

[RichieSams]

Can you confirm this still happens when using the latest daily build? What are the file sizes of the savegames?

In my tests, saves are about 1-2 seconds. But I will do some profiling to find out more

[mim]

Yes, it is the same in Feb 5 2016 9:53 build. The savegames size: 466kB, 489kB, 488kB. 13 seconds saving time now with stopwatch.

[RichieSams]

Thank you for the update. Can you attach one of the savegames?

[mim]

Yes, the savegame attached.

[Eugene Sandulenko]

Fixed. It was combination of poor reallocation strategy in ScummVM and poor memory management in Windows.

During the save we were reallocating 15.5GB of memory, which was a single save growing from 3 bytes to 1.2MB.

Now after fix we are reallocating 4.5MB, e.g. 300 times less.