#6885 INDY3: FMTOWNS: Music is distorted (regression)

[kirben]

ScummVM 1.8.0git4631-gedd95b3 (Aug 30 2015 13:13:44) on Windows 7 (SP1)
Compiled with GCC 4.6.2 under MinGW

The FM Towns version of Indiana Jones and the Last Crusade

The three sound resources (29, 54, 66) used for music sound distorted/strange and definitely not right. The music used lasted worked in ScummVM 1.1.1, and were broken somewhere between version ScummVM 1.2.0.

[digitall]

@kirben: There are 3627 commits between v1.1.1 and v1.2.0 tags. Is it possible for you to do a "git bisect v1.1.1..v1.2.0" to try to narrow this down?

I see a few possible likely commits including 85a15e05b08d464364b26fe88fee69e0d9bddf43 and 4c588d0f0b730496190d7cf42dd4eff547dc25c9, but best if we can narrow it down further...

[kirben]

Unfortunately I'm no longer able to configure/compile code that old, but I suspect the problem occured when the FM-Towns audio driver was rewritten.

[digitall]

@kirben: I suspected that might be the case. My patches from bug #2687 may allow you to do that with newer GCC compilers... http://sourceforge.net/p/scummvm/bugs/_discuss/thread/ac77d3b4/ec7a/attachment/build-scripts-for-gcc-4.tar.gz

Otherwise, I can probably provide builds done on the buildbot if that would help to allow bisection. I would do this myself, but I don't own any of the FM-TOWNS versions.

[Torbjörn Andersson]

The sound of the kazoo in FM-Towns Zak McKracken changed - to the better, I thought - in 29a5c6a45b90e64cf5d618da4cdcd6e6da3425fb ("SCUMM/FM-TOWNS: start rewriting audio code"), but perhaps that's completely unrelated?

Anyway, I was able to compile ScummVM 1.1.0 with GCC 4.9 by replacing -ansi with -fpermissive in the generated config.mk.

[kirben]

The configure script is crashing GCC 4.6.2 under Mingw, at 'Type with 2 bytes...' check, when I tried to use older SummVM code.

[kirben]

The kazoo in Zak McKracken (FM-Towns) uses the same sound type (1), maybe it isn't effected, since it is so short?

[Torbjörn Andersson]

Maybe the configure crash is what commit bd253a62aca2a0571ad61a3167278d3c5437467a ("BUILD: Support newer MinGW compilers.") was about, i.e. where "TMP" was changed to "TMPR"?

[kirben]

The regression occured when the FM-Towns audio driver was rewritten, as expected, specifically in this commit:
29a5c6a45b90e64cf5d618da4cdcd6e6da3425fb
SCUMM/FM-TOWNS: start rewriting audio code

[digitall]

kirben, eriktorbjorn: Thanks for doing that.

[athrxx]

It took me some time to start looking into this, since I've lost all my ScummVM and IDA files. This seems to be a signed/unsigned issue which occurs only with tracks with certain header data. But I'll have to make a new Indy3 disasm which will take some more time. Not as long as it may sound though, since I know what I am looking for...

[athrxx]

This should now be fixed.

[kirben]

Yes, the music tracks are fine with latest ScummVM GiT.