#6781 ZVISION: Animation glitch (position? scaling?) in Nemesis laboratory

[Torbjörn Andersson]

Current git snapshot of ScummVM
English Zork Nemesis, included on ZGI DVD version

In the attached savegame, you can click on the red picture on the desk to reveal a picture of a violinist underneath. But the animation doesn't line up with the background, creating a very noticeable seam. This does not happen in the original interpreter. At least not in the DOS version.

[Torbjörn Andersson]

Here is a screenshot during the animation.

[Torbjörn Andersson]

I tried capturing the same image in DOSBox. This is as close as I got. It's not the exact same frame, but to me it does seem to suggest that it's scaling, not position, that is off.

[Torbjörn Andersson]

The problem seems to be that it's scaling down the animation (I don't yet know the reason why). If I force it to draw the animation at the actual size, it matches the background as well as can be expected.

[Torbjörn Andersson]

These scripts, from tl9e.scr, seem to be responsible for setting up the animation. So it appears that it's the scripts that specify too little space for the frames. Did the original ignore the specified size in some cases? If so, when?

(They don't appear after each other like this in the original script file, but GitHub merged the text blocks together when I tried to separate them.)

puzzle:1283 {               # TL9E Hide Photo puzl
              criteria { 
                            [1280] = 1                  # tl9e hide photo
              }
              results {
                            action:assign(1280, 0)      # tl9e hide photo
                            action:assign(1283, 0)      # TL9E Hide Photo puzl
                            action:disable_control(1280)               # tl9e hide photo
                            action:disable_control(1278)               # tl9e Get Photo
                            action:syncsound(27030 0 tl9eq1sc.raw 22050 16 0 0) #a
                            background:playpreload:1282(27030 146 142 297 229 12 22 1)
              }
              flags {
                            ONCE_PER_INST
              }
}

puzzle:1290 {               # TL9E Reveal Photo pzl
              criteria { 
                            [1287] = 1                  # tl9e Reveal Photo
              }
              results {
                            action:assign(1287, 0)      # tl9e Reveal Photo
                            action:assign(1290, 0)      # TL9E Reveal Photo pzl
                            action:disable_control(1287)               # tl9e Reveal Photo
                            action:syncsound(27030 0 tl9eq1sc.raw 22050 16 0 0) #a
                            background:playpreload:1289(27030 146 142 297 229 0 11 1)
              }
              flags {
                            ONCE_PER_INST
              }
}

[Torbjörn Andersson]

Another example of scaling gone wrong is the fist controls. Here are screenshots of DOSBox, ScummVM and ScummVM where fist_control.cpp calls blitSurfaceToBkg() instead of blitSurfaceToBkgScaled().

[Torbjörn Andersson]

The "fists" glitch had already been filed as bug #6784, Earth pavilion door puzzle inset videos out of alignment

[RichieSams]

Can you confirm that this was fixed by commit 1adcb23d7

[Filippos Karapetis]

The bug in the Nemesis laboratory is not related to the fist door puzzle (which is fixed by commit 1adcb23d7)