#6494 TEENAGENT: Yet another unimplemented callback

*None
closed-fixed
digitall
None
5
2014-01-13
2014-01-11
No

This time built from git current, in the second chapter, next to a squirrel in a tree there is a nut. If you try to examine the nut, you get the unimplemented callback 0x5634.
I provide a savegame to reproduce it.

1 Attachments

Discussion

  • Mario Rugiero

    Mario Rugiero - 2014-01-11

    Also, may I advise to change the error for the unimplemented cases to a warning? That would be less disruptive.

     
  • Mario Rugiero

    Mario Rugiero - 2014-01-11

    Another one, using the chainsaw on the branch, in the back of the mansion.
    Callback 0x830b.

     
  • Mario Rugiero

    Mario Rugiero - 2014-01-11

    Added a patch for the missing callback 0x830b

     
  • Mario Rugiero

    Mario Rugiero - 2014-01-11

    Added a patch for substituting the missing callback errors for a warning.

     
  • Johannes Schickel

    I think the main issue with a warning is that nearly no user would ever see such a warning because it's only printed in the log and/or on stderr. As a result we wouldn't get bug reports like this.

     
  • digitall

    digitall - 2014-01-13
    • assigned_to: digitall
     
  • digitall

    digitall - 2014-01-13

    As Lordhoto said, unimplemented callbacks now trigger error() rather than warning() to ensure we get user feedback such as this.

    The original hacky decoding for dealing with them was removed in 31cb5ce3f1e970699318e1c7cbfe1ae57804a14c. I had thought I had got all the missing ones, but it appears I missed a few. Will fix these two.

     
  • digitall

    digitall - 2014-01-13

    Fixed both missing callbacks in commit 4df249b9cec6c9d4ecc0aa8129beb816379d77fa. Closing this bug as fixed.

    Mario, please test with the next nightly build / git build and feel free to reopen this if you get any more missing callback errors.

     
  • digitall

    digitall - 2014-01-13
    • status: open --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks