#5730 AGI: Winnie: Color flood fill issue

[Thunderforge]

Mac OS X
ScummVM 1.3.0
English
DOS
Winnie the Pooh in the Hundred Acre Wood

When playing the game and picking up the coat, which is purple in color, dropping it on a screen that has a white background causes the white background to become purple. I saw this on a number of screens, but the most obvious was on the map with Roo. He is surrounded by white sand, but dropping the coat makes it all turn the same color as the purple coat until it is picked back up.

[Thunderforge]

Screenshot with correct palette before dropping the coat

[Thunderforge]

Screenshot with incorrect palette after dropping the coat

[Thunderforge]

Savegame with the coat

[Thunderforge]

Added a savegame where the player already has picked up the coat. (Look in the toychest at the start of the game to load the save). You can drop it in the starting room to see a small graphics glitch of this sort in the bottom corner. To get to Roo's screen as shown in the attached screenshots, go West, North, North, North, North.

[clone2727]

This isn't a palette issue (the game's palette never changes). This looks like a flood fill issue where our picture code continues to fill in the pink color beyond the edge of the coat (there's a gap in the black outline and it spills out into the white of the ground).

[Eugene Sandulenko]

This bug is nice to get fixed before the release. Raising priority for keeping the track.

[Filippos Karapetis]

Updated description, this is a flood fill issue

[clone2727]

As far as I can tell, our flood fill routine is pretty wrong here altogether. If you notice, the dark green color of the grass and trees isn't present in the screenshot either. That is, except for one pixel in the grass, which is the point where the fill starts. It sees it's surrounded by black pixels, and bails out. We should check the NAGI implementation and see if that's better, or see if winnie does something different and only uses priority for fill.