Menu
▾
▴
#4928 AGI: SQ2 : Falling Off Log Almost Immediate
In Space Quest II: Vohaul's Revenge (2.0F 1989-01-05 3.5"/DOS/English) (AGI) :
When you try to "Climb Log" to cross the Chasm, you fall off almost immediately as if you had tried to stand..
ScummVM 1.2.0svn51067 (Jul 20 2010 18:47:29)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ RGB zLib FluidSynth
on Linux 2.6.34 x86_32
Savegame For Replication
For clarity, this bug prevents game completion and is found in Room 16.
The engine reports "Emulating Sierra AGI v2.936".
I have bisected this and have found that the issue was introduced by r49744 :
r49744 | sev | 2010-06-15 11:32:01 +0100 (Tue, 15 Jun 2010) | 4 lines
AGI: Fix bug #1875842.
Bug #1875842: "AGI: Character loses final walking position".
Do not reset ADJ_EGO_XY if non-directional keys were pressed.
---
It is likely that this is causing a spurious keyboard movement event after "Climb Log"
which means Roger immediately stands up and dies.
This bug is nice to get fixed before the release. Raising priority for keeping the track.
I can still replicate this with v1.2.0 branch SVN r52828.
I'm not sure why Scarlatti didn't hit this when playtesting with r52740, but I suspect may either be due to the differences between V2.0A and V2.0F, or platform.
I tried it out with svn52835 and v2.0A, using a savegame. It still works fine. I'm able to climb the log, cross the chasm both ways and tie the rope later without any problems.
I can reproduce the bug with my copy of 2.0F. Though it doesn't happen if I walk around a bit before I climb the log. (Even just pressing "5" to stop walking works.)
And I just noticed that if I use the mouse to walk around a bit, I still fall off. I have to use the keyboard to stop to avoid it.
So maybe there should simply be a v->flags &= ~ADJ_EGO_XY; is mainCycle() when it notices that you've reached your destination? On the other hand, that still doesn't restore the old behaviour where it seem that pressing any key whatsoever (e.g. to type "climb log") would clear the flag.
I don't know, I'm just not familiar enough with the AGI engine.
Attaching savegame of the other point this occurs i.e. "Climb Tree" to go over the gorge left to right.
I agree with eriktorbjorn in that it is avoidable. It only seems to occur if you use the keyboard to walk to the tree and are stopped by it before typing "Climb Tree" i.e. you fall off because the keyboard walking is still locked in.
Will have to try this with original interpreter under DosBox to confirm that this behaviour does differ from original though.
"Climb Tree" Savegame for first case of bug i.e. first crossing of Log
Original intrepreter savegame for "Climb Tree" comparison
Original interpreter under DosBox does not seem to exhibit this behaviour i.e. real regression.
Attached original interpreter savegame to allow comparison.
> It only seems to occur if you use the keyboard to walk to the tree
> and are stopped by it before typing "Climb Tree"
I'm not sure I understand... I wasn't able to reproduce it at all when using the keyboard to walk. Even typing "climb log" while still moving seemed to be safe.
If I used the mouse to move instead - and I wouldn't be surprised if many players do - I couldn't find any way to cross safely.
NAGI savegame near fissure.
Sev asked me to try if I could reproduce the bug with NAGI. I couldn't, not even by typing "climb log" while walking with the mouse. (I don't think my proposed patch covers that case.) I've attached a savegame.
Just like in ScummVM, you still have to use the keyboard to cross the log. (Unless you're very, very precise, I guess.)
The latest released NAGI source code wouldn't build on my computer, but the version at http://github.com/sonneveld/nagi worked.
digitall, can you please try out my current pull request, if it fixes this issue?
I just looked into it and it seems our whole user key -> direction handling was inaccurate. On top our VM Var 6 <-> ego direction handling was inaccurate as well. At least I can walk to the log with the mouse or via keyboard, then enter "climb log" and I won't fall off. It seems I have to press left to successfully climb the log. When I use the mouse, I fall off. Although maybe I would have to click better?!
Will give it a try and update this when I have.
Commit 8a595e7771aa89d06876e13d7ab6751e26da8982 was just accepted (as well as plenty of others). Bug needs to be checked. As I said - no idea if climbing over with the mouse is supposed to work. Maybe someone should check a version, that has official mouse support and check, if the original interpreter lets you fall off as well. At least I'm not falling off immediately, only when I click somewhere while ego is actually climbing.