#4575 FT: Issue with subtitles in French version

[JLK]

There is an issue with subtitles before the final fight against Ripburger.

A screenshot is better than long (and boring) explanations, please see my file attachment.

[JLK]

Screenshot of the wrong subtitle display

[Eugene Sandulenko]

Could you also provide the savefile?

[Eugene Sandulenko]

For the record, Ubuntu, 1.1.0svn43727

[digitall]

JLK: There have been a number of corrections to Subtitle functions in SCUMM for FT. Please can you confirm if this is still occuring with the current stable release version i.e. v1.3.1 and if so, can you try a daily build from:
http://www.scummvm.org/downloads/#daily
And confirm if this is still present in current development master.

Thanks.

[digitall]

SylvainTV has this version and is going to try to replicate/confirm that this is fixed when he has time.

For reference, Boot Param 900 can be used to jump to the relevant section in ScummVM:
http://wiki.scummvm.org/index.php/Boot_Params#Full_Throttle
The same parameter can be used with the original interpreter for comparison using the debug mode:
http://wiki.scummvm.org/index.php/SCUMM/Debug_Codes#Full_Throttle

[digitall]

SylvainTV reports that this is still occuring with latest Git master.
From the attached screenshot, it looks like the subtitle newline symbol is not being recognised?

[Sylvain Dupont]

These are the good subtitles in the French version played in DOSbox

[Sylvain Dupont]

Added a picture with good subtitles in DosBox

[Sylvain Dupont]

After further checks I noticed that the function to draw this text was :

void SmushFont::drawString(const char *str, byte *buffer, int dst_width, int dst_height, int x, int y, bool center)

There is no newline in str, and drawString does not cut the line.

[kirben]

There is a separate function (drawStringWrap) for wrapping the subtitles during smush scenes. The exact function to use, is selected by SmushPlayer::handleTextResource() in engines/scumm/smush/smush_player.cpp.

So check the bit values for flags in SmushPlayer::handleTextResource() during this scene, to see if there are any unexpected cases.

[Sylvain Dupont]

In SmushPlayer::handleTextResource() in engines/scumm/smush/smush_player.cpp.

// bit 0 - center 1
// bit 1 - not used 2
// bit 2 - ??? 4
// bit 3 - wrap around 8

The flag for both badly-displayed texts is "5". So it's treated as "1" without wrapping.

[digitall]

In the English version, this flag field is 13 i.e. 1101 binary which is masked off by 9 i.e. 1001 binary.. Looks like the unknown field in this is a duplicate wrap around flag. Attaching proposed patch to implement this.

[digitall]

Proposed Patch to deal with duplicate wraparound flag

[digitall]

Ah, after discussion with SylvainTV and some checking, this understanding is not correct either. Attaching a new proposed patch to fix this, but we will need to check as it appears to cause some regressions in FT French... despite correcting this fault.

[digitall]

Proposed Patch to correct SMUSH Text Flags meanings