#1086 ALL: Fullscreen and -F

All Games
closed-fixed
Graphics (902)
5
2003-08-15
2003-07-28
Jellby
No

I'm not sure if this is "GUI" or "Graphics"...

I have, in my ~/.scummvrc file (RedHat 7.3)https://sourceforge.
net/tracker/?func=add&group_id=37116&atid=516929, all games set
to "fullscreen=true", only the may [scummvm] section is set to
"fullscreen=false". I wanted a way to start a given game in
windowed mode (not fullscreen) using a command-line option and I
was told the "-F" option was the one I needed (though it's not
documented, as far as I know). These are some of the results. I first
set [scummvm] to "fullscreen=true" to test this.

$ scummvm -v
ScummVM 0.5.0pre-cvs (Jul 27 2003 13:47:16)

$ scummvm -F
[ok, the GUI starts in windowed mode]

$ scummvm -F monkey
[monkey island starts fullscreen]

$ scummvm -F tentacle
[dott starts fullscreen]

$ scummvm -F simon
Looking for simon1talkie
Trying to start game 'Simon the Sorcerer 1 Talkie (DOS)'
ALSA client initialised [65:0]
scummvm: backends/sdl/sdl.cpp:346: virtual uint32 OSystem_SDL::
property(int, OSystem::Property*): Assertion `_hwscreen != 0' failed.
Aborted

$ scummvm -F sky
Looking for sky
Trying to start game 'Beneath a Steel Sky'
ALSA client initialised [65:0]
scummvm: backends/sdl/sdl.cpp:346: virtual uint32 OSystem_SDL::
property(int, OSystem::Property*): Assertion `_hwscreen != 0' failed.
Aborted

Something is not working right here...

Discussion

  • Torbjörn Andersson

    Logged In: YES
    user_id=577918

    I can reproduce this under Windows with the SDL backend,
    too. It appears that SimonEngine::SimonEngine() toggles
    fullscreen in the backend before the backend has had the
    time to create _hwscreen.

    Actually, it seems to be enough to just put
    "fullscreen=true" in the config file.

    Is it just my imagination, or is the config stuff at the end
    of SimonEngine::SimonEngine() completely unnecessary? As far
    as I can tell, it works just fine without it. (Except maybe
    when starting from the launcher, but as far as I can see
    this code doesn't help there either.)

     
  • Torbjörn Andersson

    • assigned_to: nobody --> kirben
     
  • Torbjörn Andersson

    Logged In: YES
    user_id=577918

    Assigning to kirben since he's the one who added that code
    to the Simon engine; he should know which case it's needed for.

     
  • Jellby

    Jellby - 2003-07-29

    Logged In: YES
    user_id=655443

    Two comments:

    1. I was looking for an option to override "fullscreen=true" and start a
    game *not* in fullscreen mode. If "-F" is such an option, it failed with all the
    games I tried (but it worked with the game selector).

    2. Beneath a Steel Sky gives the same error as Simon

     
  • Marek Roth

    Marek Roth - 2003-07-29

    Logged In: YES
    user_id=123766

    For me it works fine, if the "fulscreen=true" line is only
    present in the [scummvm] section and it is absend for the
    particular game entry.
    I have not tried this for the game entries before, since it
    makes no sense for me to have a only particular game in
    window mode and another in full screen. The only reason
    using window mode is watching the debug output or the
    original interpreter aside of ScummVM. This usually does not
    go for a particular game.

    Maybe the game specific entry has just to be ignored when
    '-f' or '-F' is given. It should be overwritten anyway.

     
  • Torbjörn Andersson

    Logged In: YES
    user_id=577918

    I've committed a fix that keeps Simon and BASS from crashing.

    The bug isn't fixed though, since the config file still
    overrides the command-line option. But it's a start.

     
  • kirben

    kirben - 2003-07-30
    • assigned_to: kirben --> nobody
     
  • kirben

    kirben - 2003-07-30

    Logged In: YES
    user_id=34715

    That code in Simon is to allow a game specific full screen or
    scaler to work if a game is started via launcher.
    This should be fixed by someone else, as the remaining issue
    effects all modules (scumm/simon/sky).

     
  • Max Horn

    Max Horn - 2003-07-31
    • summary: Fullscreen and -F --> ALL: Fullscreen and -F
    • labels: 450906 --> Graphics
     
  • James Brown

    James Brown - 2003-08-09

    Logged In: YES
    user_id=2715

    This option should also be renamed to --no-f and probably
    aliased to --no-fullscreen, in order to corrospond with
    our current documentation and naming scheme.

     
  • Jamieson Christian

    Logged In: YES
    user_id=596642

    -f and -F should be fixed in latest CVS, as well as other
    command line options that are assumed to be [scummvm]
    scope by default (such as -g). Also added --fullscreen and --
    no-fullscreen to the options. (No, I did not add a --no-f
    option. The idea of long options is to be able to spell things
    out!)

    Will wait for verification (eriktorbjorn?) before closing.

     
  • Jamieson Christian

    • assigned_to: nobody --> jamieson630
    • status: open --> open-fixed
     
  • Jonathan Gray

    Jonathan Gray - 2003-08-15

    Logged In: YES
    user_id=59347

    works here with scumm/simon/sky
    surely this can be closed now?

     
  • James Brown

    James Brown - 2003-08-15

    Logged In: YES
    user_id=2715

    Yes it can, it can.

     
  • James Brown

    James Brown - 2003-08-15
    • status: open-fixed --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks