Re: [Scst-devel] 2.6.17 ?

[Nathaniel C. <uto...@mi...>]

Yup, I found that Friday but didn't have time to repatch.  Here's the updat=
ed=20
patch.

 - Nate

On Monday 21 August 2006 8:14 am, Vladislav Bolkhovitin wrote:
> Hi Nate,
>=20
> There are some issues with the new patch.
>=20
> 1. The initiator driver doesn't work in with the target-supporting mode,=
=20
> because you missed (overdeleted):
>=20
> #if defined(CONFIG_SCSI_QLA2XXX_TARGET)
> # ifndef FC_TARGET_SUPPORT
> #  define FC_TARGET_SUPPORT 1
> # endif
> #endif
>=20
> in qla_def.h
>=20
> 2. The compiler claims:
>=20
> drivers/scsi/qla2xxx/qla_init.c: In function =E2=80=98qla2x00_chip_diag=
=E2=80=99:
> drivers/scsi/qla2xxx/qla_init.c:662: warning: =E2=80=98cnt=E2=80=99 may b=
e used=20
> uninitialized in this function
>=20
> and it's right, the code has a serious bug. If it isn't fully yours=20
> doesn't mean you should leave it unfixed.
>=20
> 3. There are pretty untidy formatting in qla2x00_chip_diag().
>=20
> Here is the patch fixing them. Recommit=20
> linux-scst-2.6.16-qla2xxx-target.patch, please.
>=20
> Could you be more accurate in the future, please?
>=20
> Vlad
>=20
> Nathaniel Clark wrote:
> > Yup.
> >=20
> > Here it is.  I'll also check it into CVS, but that may take a little wh=
ile=20
to=20
> > propogate to Anon CVS.
> >=20
> >  - Nathaniel Clark
>=20