[Scst-svn] SF.net SVN: scst:[5613] trunk/scst/src/scst_targ.c

[<vl...@us...>]

Revision: 5613
          http://sourceforge.net/p/scst/svn/5613
Author:   vlnb
Date:     2014-06-20 04:00:41 +0000 (Fri, 20 Jun 2014)
Log Message:
-----------
scst: Convert a loop to keep smatch happy

Avoid that smatch reports the following warning:
scst_init_session() info: loop could be replaced with if statement.

Signed-off-by: Bart Van Assche <bva...@ac...>

Modified Paths:
--------------
    trunk/scst/src/scst_targ.c

Modified: trunk/scst/src/scst_targ.c
===================================================================
--- trunk/scst/src/scst_targ.c	2014-06-19 12:48:25 UTC (rev 5612)
+++ trunk/scst/src/scst_targ.c	2014-06-20 04:00:41 UTC (rev 5613)
@@ -7025,7 +7025,7 @@
 static int scst_init_session(struct scst_session *sess)
 {
 	int res = 0;
-	struct scst_cmd *cmd;
+	struct scst_cmd *cmd, *cmd_tmp;
 	struct scst_mgmt_cmd *mcmd, *tm;
 	int mwake = 0;
 
@@ -7096,16 +7096,14 @@
 	else
 		sess->init_phase = SCST_SESS_IPH_FAILED;
 
-restart:
-	list_for_each_entry(cmd, &sess->init_deferred_cmd_list,
-				cmd_list_entry) {
+	list_for_each_entry_safe(cmd, cmd_tmp, &sess->init_deferred_cmd_list,
+				 cmd_list_entry) {
 		TRACE_DBG("Deleting cmd %p from init deferred cmd list", cmd);
 		list_del(&cmd->cmd_list_entry);
 		atomic_dec(&sess->sess_cmd_count);
 		spin_unlock_irq(&sess->sess_list_lock);
 		scst_cmd_init_done(cmd, SCST_CONTEXT_THREAD);
 		spin_lock_irq(&sess->sess_list_lock);
-		goto restart;
 	}
 
 	spin_lock(&scst_mcmd_lock);

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.